[PATCH] D53985: Use C++11 fallthrough attribute syntax when available and add a break

2018-11-01 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. In https://reviews.llvm.org/D53985#1284282, @aaron.ballman wrote: > In https://reviews.llvm.org/D53985#1284246, @rnk wrote: > > > In https://reviews.llvm.org/D53985#1284196, @ldionne wrote: > > > > > Would it make sense to add the GNU spelling to the attribute in Clang? >

[PATCH] D53985: Use C++11 fallthrough attribute syntax when available and add a break

2018-11-01 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In https://reviews.llvm.org/D53985#1284246, @rnk wrote: > In https://reviews.llvm.org/D53985#1284196, @ldionne wrote: > > > Would it make sense to add the GNU spelling to the attribute in Clang? > > > I'll redirect that question to @rsmith and @aaron.ballman. I

[PATCH] D53985: Use C++11 fallthrough attribute syntax when available and add a break

2018-11-01 Thread Reid Kleckner via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL345870: Use C++11 fallthrough attribute syntax when available and add a break (authored by rnk, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D53985: Use C++11 fallthrough attribute syntax when available and add a break

2018-11-01 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added subscribers: aaron.ballman, rsmith. rnk added a comment. In https://reviews.llvm.org/D53985#1284196, @ldionne wrote: > Would it make sense to add the GNU spelling to the attribute in Clang? I'll redirect that question to @rsmith and @aaron.ballman. I have a vague recollection that

[PATCH] D53985: Use C++11 fallthrough attribute syntax when available and add a break

2018-11-01 Thread Louis Dionne via Phabricator via cfe-commits
ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. Would it make sense to add the GNU spelling to the attribute in Clang? https://reviews.llvm.org/D53985 ___ cfe-commits mailing list

[PATCH] D53985: Use C++11 fallthrough attribute syntax when available and add a break

2018-11-01 Thread Reid Kleckner via Phabricator via cfe-commits
rnk created this revision. rnk added reviewers: EricWF, ldionne. Herald added subscribers: erik.pilkington, christof. This silences the two -Wimplicit-fallthrough warnings clang finds in ItaniumDemangle.h in libc++abi. Clang does not have a GNU attribute spelling for this attribute, so this is