[PATCH] D54169: [clang-tidy] Zircon ->

juliehockett abandoned this revision. juliehockett added a comment. After a lot of discussion, we'll do this migration internally. Thanks for your comments! https://reviews.llvm.org/D54169 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D54169: [clang-tidy] Zircon ->

steveire added a comment. This is https://bugs.llvm.org//show_bug.cgi?id=32739 . I think checks not relevant to a general audience (ie including the boost directory) should be in external plugins. It's not really clear to me what has to happen for that, but it seems increasingly relevant. htt

[PATCH] D54169: [clang-tidy] Zircon ->

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/zircon/FblLimitsCheck.cpp:47 +SrcMgr::CharacteristicKind FileType) { + if (FileName == "fbl/limits.h") { +unsigned End = std::strcspn(SM.getCharacterData(HashLoc), "\n") + 1; j

[PATCH] D54169: [clang-tidy] Zircon ->

juliehockett added inline comments. Comment at: clang-tools-extra/clang-tidy/zircon/FblLimitsCheck.cpp:47 +SrcMgr::CharacteristicKind FileType) { + if (FileName == "fbl/limits.h") { +unsigned End = std::strcspn(SM.getCharacterData(HashLoc), "\n") + 1; aa

[PATCH] D54169: [clang-tidy] Zircon ->

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/zircon/FblLimitsCheck.cpp:47 +SrcMgr::CharacteristicKind FileType) { + if (FileName == "fbl/limits.h") { +unsigned End = std::strcspn(SM.getCharacterData(HashLoc), "\n") + 1; j

[PATCH] D54169: [clang-tidy] Zircon ->

juliehockett added inline comments. Comment at: clang-tools-extra/clang-tidy/zircon/FblLimitsCheck.cpp:47 +SrcMgr::CharacteristicKind FileType) { + if (FileName == "fbl/limits.h") { +unsigned End = std::strcspn(SM.getCharacterData(HashLoc), "\n") + 1; aa

[PATCH] D54169: [clang-tidy] Zircon ->

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/zircon/FblLimitsCheck.cpp:47 +SrcMgr::CharacteristicKind FileType) { + if (FileName == "fbl/limits.h") { +unsigned End = std::strcspn(SM.getCharacterData(HashLoc), "\n") + 1; j

[PATCH] D54169: [clang-tidy] Zircon ->

juliehockett added inline comments. Comment at: clang-tools-extra/clang-tidy/zircon/FblLimitsCheck.cpp:47 +SrcMgr::CharacteristicKind FileType) { + if (FileName == "fbl/limits.h") { +unsigned End = std::strcspn(SM.getCharacterData(HashLoc), "\n") + 1; aa

[PATCH] D54169: [clang-tidy] Zircon ->

juliehockett updated this revision to Diff 172891. juliehockett marked 5 inline comments as done. https://reviews.llvm.org/D54169 Files: clang-tools-extra/clang-tidy/zircon/CMakeLists.txt clang-tools-extra/clang-tidy/zircon/FblLimitsCheck.cpp clang-tools-extra/clang-tidy/zircon/FblLimitsChe

[PATCH] D54169: [clang-tidy] Zircon ->

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/zircon/FblLimitsCheck.cpp:47 +SrcMgr::CharacteristicKind FileType) { + if (FileName == "fbl/limits.h") { +unsigned End = std::strcspn(SM.getCharacterData(HashLoc), "\n") + 1; D

[PATCH] D54169: [clang-tidy] Zircon ->

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/zircon/FblLimitsCheck.cpp:111 + // Add in the header, since we know this file uses it. + if (auto IncludeFixit = Inserter->CreateIncludeInsertion( + SM.getFileID(V->getLocation()), "limits"

[PATCH] D54169: [clang-tidy] Zircon ->

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D54169 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

[PATCH] D54169: [clang-tidy] Zircon ->

juliehockett created this revision. juliehockett added reviewers: aaron.ballman, alexfh, hokein. juliehockett added a project: clang-tools-extra. Herald added subscribers: xazax.hun, mgorny. Adds a check to convert to std . This check is part of a set of migration checks as we prepare to move Zi