[PATCH] D54402: Extract method to allow re-use

steveire updated this revision to Diff 173820. steveire added a comment. Update Repository: rC Clang https://reviews.llvm.org/D54402 Files: lib/ASTMatchers/Dynamic/Registry.cpp Index: lib/ASTMatchers/Dynamic/Registry.cpp ===

[PATCH] D54402: Extract method to allow re-use

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In https://reviews.llvm.org/D54402#1296273, @steveire wrote: > This is just a NFC change, which is normal to appear without tests. The > consensus on IRC is that this is fine.

[PATCH] D54402: Extract method to allow re-use

steveire added a comment. This is just a NFC change, which is normal to appear without tests. The consensus on IRC is that this is fine. Repository: rC Clang https://reviews.llvm.org/D54402 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D54402: Extract method to allow re-use

aaron.ballman added a comment. In https://reviews.llvm.org/D54402#1295420, @steveire wrote: > I think this commit is fine without tests. That's not something we do except under specific extenuating circumstances (NFC fixes or changes for which existing coverage suffices), per our developer po

[PATCH] D54402: Extract method to allow re-use

steveire updated this revision to Diff 173764. steveire added a comment. Update Repository: rC Clang https://reviews.llvm.org/D54402 Files: lib/ASTMatchers/Dynamic/Registry.cpp Index: lib/ASTMatchers/Dynamic/Registry.cpp ===

[PATCH] D54402: Extract method to allow re-use

steveire added a comment. I think this commit is fine without tests. The new method remains internal to the file but follow-up commits add public interface and tests. I'll push the commits separately. I'll not be squashing them. Repository: rC Clang https://reviews.llvm.org/D54402 __

[PATCH] D54402: Extract method to allow re-use

aaron.ballman added a comment. Generally LGTM but this has no test coverage. What are your plans for how you want to see this proceed? Do you intend to commit everything in one batch once all of the reviews are accepted, or do piecemeal commits? Comment at: lib/ASTMatchers/Dy

[PATCH] D54402: Extract method to allow re-use

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. The list of matchers which can be used with a top matcher can be used in other contexts than code completion. It can be output as data in clang-tidy. Repository: rC Clang https://