[PATCH] D54408: [ASTMatchers] Add matchers available through casting to derived

2020-05-26 Thread Stephen Kelly via Phabricator via cfe-commits
steveire added a comment. @aaron.ballman I think we agreed in Belfast in November (after the most recent comment) to get this in as it is and not be as draconian about `auto`. Is anything blocking this? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54408/new/

[PATCH] D54408: [ASTMatchers] Add matchers available through casting to derived

2020-05-30 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D54408#2056251 , @steveire wrote: > @aaron.ballman I think we agreed in Belfast in November (after the most > recent comment) to get

[PATCH] D54408: [ASTMatchers] Add matchers available through casting to derived

2019-09-05 Thread Andi via Phabricator via cfe-commits
Abpostelnicu added a comment. Herald added a project: clang. @aaron.ballman I think the auto usage improves and simplifies the code, however, as I would really like to see this code landed, I would be ok to help Steven to finish this work and replace auto by the "old" way. Do you think we can h

[PATCH] D54408: [ASTMatchers] Add matchers available through casting to derived

2019-09-05 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D54408#1659301 , @Abpostelnicu wrote: > @aaron.ballman > I think the auto usage improves and simplifies the code, however, as I would > really like to see this code landed, I would be ok to help Stephen to finish > th

[PATCH] D54408: [ASTMatchers] Add matchers available through casting to derived

2018-12-30 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. Differential lacks description. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54408/new/ https://reviews.llvm.org/D54408 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://list

[PATCH] D54408: [ASTMatchers] Add matchers available through casting to derived

2018-12-31 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: lib/ASTMatchers/Dynamic/Registry.cpp:651 +llvm::Optional> +getNodeConstructorType(MatcherCtor targetCtor) { + const auto &ctors = RegistryData->nodeConstructors(); targetCtor -> TargetCtor Comme

[PATCH] D54408: [ASTMatchers] Add matchers available through casting to derived

2019-01-02 Thread Stephen Kelly via Phabricator via cfe-commits
steveire updated this revision to Diff 179953. steveire added a comment. Case Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54408/new/ https://reviews.llvm.org/D54408 Files: lib/ASTMatchers/Dynamic/Registry.cpp unittests/ASTMatchers/Dynamic/RegistryTest.cpp