[PATCH] D54408: Add matchers available through casting to derived

steveire updated this revision to Diff 179725. steveire added a comment. Some updates Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54408/new/ https://reviews.llvm.org/D54408 Files: lib/ASTMatchers/Dynamic/Registry.cpp unittests/ASTMatchers/Dynamic/RegistryT

[PATCH] D54408: Add matchers available through casting to derived

aaron.ballman added inline comments. Comment at: lib/ASTMatchers/Dynamic/Registry.cpp:645 +getNodeConstructorType(MatcherCtor targetCtor) { + auto const &ctors = RegistryData->nodeConstructors(); + Don't use `auto` here (and if you did. the `const` would go on t

[PATCH] D54408: Add matchers available through casting to derived

steveire updated this revision to Diff 173770. steveire added a comment. Update Repository: rC Clang https://reviews.llvm.org/D54408 Files: lib/ASTMatchers/Dynamic/Registry.cpp unittests/ASTMatchers/Dynamic/RegistryTest.cpp Index: unittests/ASTMatchers/Dynamic/RegistryTest.cpp =

[PATCH] D54408: Add matchers available through casting to derived

steveire added a comment. These commits are available on github if it's convenient to see it all together there: https://github.com/steveire/clang/commits/matcher-output Here is context for the changes I'm making in case it is useful: https://steveire.wordpress.com/2018/11/11/future-developmen

[PATCH] D54408: Add matchers available through casting to derived

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D54408 Files: lib/ASTMatchers/Dynamic/Registry.cpp unittests/ASTMatchers/Dynamic/RegistryTest.cpp Index: unittests/ASTMatchers/Dy