This revision was automatically updated to reflect the committed changes.
Closed by commit rL347297: [clangd] Allow observation of changes to global
CDBs. (authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D54475
Files
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: clangd/Function.h:147
+private:
+ static_assert(std::is_same::type, T>::value,
+"use a plain type: event values are always pas
sammccall added inline comments.
Comment at: clangd/Function.h:147
+private:
+ static_assert(std::is_same::type, T>::value,
+"use a plain type: event values are always passed by const&");
ilya-biryukov wrote:
> NIT: Maybe move this static_assert
sammccall updated this revision to Diff 174633.
sammccall marked 2 inline comments as done.
sammccall added a comment.
Herald added a subscriber: mgorny.
Address comments, add test for Event machinery.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D54475
Files:
clangd/Functio
ilya-biryukov requested changes to this revision.
ilya-biryukov added inline comments.
This revision now requires changes to proceed.
Comment at: clangd/Function.h:108
+Subscription &operator=(Subscription &&Other) {
+ std::tie(Parent, ListenerID) = std::tie(Other.Parent
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: clangd/Function.h:147
+private:
+ static_assert(std::is_same::type, T>::value,
+"use a plain type: event values are always pas
sammccall updated this revision to Diff 174014.
sammccall marked 3 inline comments as done.
sammccall added a comment.
Address comments.
Add missing OverlayCDB->Base watching (oops!)
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D54475
Files:
clangd/Function.h
clangd/Global
ilya-biryukov added inline comments.
Comment at: clangd/Function.h:90
+class Event {
+public:
+ // A Listener is the callback through which events are delivered.
I assume the `Event` is supposed to be used only with non-reference and
non-const qualified types.
sammccall created this revision.
sammccall added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
ioeric.
Currently, changes *within* CDBs are not tracked (CDB has no facility to do so).
However, discovery of new CDBs are tracked (all files a
