This revision was automatically updated to reflect the committed changes.
Closed by commit rCRT347338: [cmake] Fix detecting terminfo library (authored
by mgorny, committed by ).
Repository:
rCRT Compiler Runtime
https://reviews.llvm.org/D54641
Files:
cmake/config-ix.cmake
Index:
mgorny updated this revision to Diff 174534.
mgorny edited the summary of this revision.
mgorny added a comment.
Updated for check order change in master.
https://reviews.llvm.org/D54641
Files:
cmake/config-ix.cmake
Index: cmake/config-ix.cmake
krytarowski accepted this revision.
krytarowski added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D54641#1301620, @mgorny wrote:
> Well, sure but I think changing the order should be done separately from
> this. I'm fixing a bug resulting from people
krytarowski added a comment.
As I understand it -ltinfo vs -lterminfo is mixing native curses(3) and
external ncurses(3) from pkgsrc, while we prefer to use entirely our native
version for all LLVM projects.
Repository:
rCRT Compiler Runtime
https://reviews.llvm.org/D54641
krytarowski added a comment.
Context:
> Do not return -ltinfo from llvm-config --system-libs --link-static
>
> under NetBSD. Bump PKGREVISION
>
> Rust language 1.20.0 uses these options and Rust build system uses it
> as '-l tinfo' and our wrapper does not handle this.
krytarowski added a comment.
I have got a local patch in pkgsrc-wip/llvm-netbsd:
$NetBSD$
--- cmake/config-ix.cmake.orig2017-12-08 18:50:04.615602612 +
+++ cmake/config-ix.cmake
@@ -153,7 +153,7 @@ if(NOT LLVM_USE_SANITIZER MATCHES "Memor
endif()
mgorny created this revision.
mgorny added reviewers: krytarowski, dberris, labath.
Herald added subscribers: Sanitizers, llvm-commits.
Copy the fix for determining the correct terminfo library from LLVM --
use distinct variables for check_library_exists() calls. Otherwise,
the first check (for
