This revision was automatically updated to reflect the committed changes.
Closed by commit rC347465: [clang-format] Do not treat asm clobber [ as
ObjCExpr, refined (authored by krasimir, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D54795?vs=175038=175049#toc
Repository:
krasimir added a comment.
In https://reviews.llvm.org/D54795#1305395, @djasper wrote:
> Does this also work for _asm and __asm?
Thanks! Turns out, yes. I added tests for those.
Repository:
rC Clang
https://reviews.llvm.org/D54795
___
krasimir updated this revision to Diff 175038.
krasimir added a comment.
- Add tests for _asm etc
Repository:
rC Clang
https://reviews.llvm.org/D54795
Files:
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTest.cpp
Index: unittests/Format/FormatTest.cpp
djasper added a comment.
Does this also work for _asm and __asm?
Repository:
rC Clang
https://reviews.llvm.org/D54795
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
krasimir created this revision.
Herald added a subscriber: cfe-commits.
r346756 refined clang-format to not treat the `[` in `asm (...: [] ..)` as an
ObjCExpr. However that's not enough, as we might have a comma-separated list of
such clobbers as in the newly added test.
This updates the
