[PATCH] D54834: [analyzer][MallocChecker] Improve warning messages on double-delete errors

This revision was automatically updated to reflect the committed changes. Closed by commit rGa82810c56bc9: [analyzer][MallocChecker] Improve warning messages on double-delete errors (authored by Szelethus). Herald added a subscriber: Charusso. Herald added a project: clang. Changed prior to commi

[PATCH] D54834: [analyzer][MallocChecker] Improve warning messages on double-delete errors

NoQ added a comment. In D54834#1332679 , @Szelethus wrote: > Interesting, I've been watching the bots closely, but got no mail after a > while. I'm not sure what the cause is, so I'll revert one-by-one. One of the common reasons for that is that the bui

[PATCH] D54834: [analyzer][MallocChecker] Improve warning messages on double-delete errors

Szelethus reopened this revision. Szelethus added a comment. This revision is now accepted and ready to land. Reverted in rC349340 . With the wrong revision name... oops... Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54834/new

[PATCH] D54834: [analyzer][MallocChecker] Improve warning messages on double-delete errors

Szelethus added a comment. Interesting, I've been watching the bots closely, but got no mail after a while. I'm not sure what the cause is, so I'll revert one-by-one. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54834/new/ https://reviews.llvm.org/D54834 ___

[PATCH] D54834: [analyzer][MallocChecker] Improve warning messages on double-delete errors

NoQ added a comment. Ok, D55388 seems to have landed (3 builds without failures in move checker), so i guess these are separate problems after all. The first failing build seems to be http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/2662 - it i

[PATCH] D54834: [analyzer][MallocChecker] Improve warning messages on double-delete errors

NoQ added a comment. Wait, no, i didn't do anything with checker options yet. Something else then, i guess. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54834/new/ https://reviews.llvm.org/D54834 ___ cfe-commits ma

[PATCH] D54834: [analyzer][MallocChecker] Improve warning messages on double-delete errors

NoQ added a comment. Ugh. MSVC buildbot is acting weird again. Also it is not acting deterministically

[PATCH] D54834: [analyzer][MallocChecker] Improve warning messages on double-delete errors

NoQ added a comment. Mm, yeah, but it's still weird to see it in `checkPreCall` for `CXXDestructorCall`. I suspect that your new warning covers these tests as well. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54834/new/ https://reviews.llvm.org/D54834

[PATCH] D54834: [analyzer][MallocChecker] Improve warning messages on double-delete errors

This revision was automatically updated to reflect the committed changes. Closed by commit rC349283: [analyzer][MallocChecker] Improve warning messages on double-delete errors (authored by Szelethus, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D548

[PATCH] D54834: [analyzer][MallocChecker] Improve warning messages on double-delete errors

Szelethus marked 2 inline comments as done. Szelethus added inline comments. Comment at: test/Analysis/NewDelete-checker-test.cpp:380 delete foo; delete foo; // expected-warning {{Attempt to delete released memory}} } Right here. Comment

[PATCH] D54834: [analyzer][MallocChecker] Improve warning messages on double-delete errors

Szelethus added a comment. In D54834#1315475 , @NoQ wrote: > Thanks, nice catch! > > It seems that the `ReportDoubleDelete()` thing was never used for reporting > double-delete, but it was used for some strange check when a destructor is > called. It w

[PATCH] D54834: [analyzer][MallocChecker] Improve warning messages on double-delete errors

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thanks, nice catch! It seems that the `ReportDoubleDelete()` thing was never used for reporting double-delete, but it was used for some strange check when a destructor is called. Is that old code e

[PATCH] D54834: [analyzer][MallocChecker] Improve warning messages on double-delete errors

Szelethus created this revision. Szelethus added reviewers: george.karpenkov, NoQ, xazax.hun, rnkovacs. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, whisperity. Repository: rC Clang https://reviews.llvm.org/D54834