This revision was automatically updated to reflect the committed changes.
Closed by commit rL348145: [AST][Sema] Remove CallExpr::setNumArgs (authored by
brunoricci, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D54902?vs=175434&id=17
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM aside from two small NFC nits.
Comment at: include/clang/AST/ExprCXX.h:168
public:
- CXXMemberCallExpr(ASTContext &C, Expr *fn, ArrayRef args,
-
riccibruno added a comment.
added inline comments
Comment at: include/clang/AST/ExprCXX.h:168
public:
- CXXMemberCallExpr(ASTContext &C, Expr *fn, ArrayRef args,
-QualType t, ExprValueKind VK, SourceLocation RP)
- : CallExpr(C, CXXMemberCallExprClass,
riccibruno updated this revision to Diff 175434.
riccibruno marked 9 inline comments as done.
riccibruno added a comment.
style fixes
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D54902/new/
https://reviews.llvm.org/D54902
Files:
include/clang/AST/Expr.h
inc
aaron.ballman added inline comments.
Comment at: include/clang/AST/ExprCXX.h:168
public:
- CXXMemberCallExpr(ASTContext &C, Expr *fn, ArrayRef args,
-QualType t, ExprValueKind VK, SourceLocation RP)
- : CallExpr(C, CXXMemberCallExprClass, fn, args, t, V
riccibruno created this revision.
riccibruno added reviewers: rsmith, aaron.ballman.
riccibruno added a project: clang.
Herald added subscribers: cfe-commits, dexonsmith, mehdi_amini.
`CallExpr::setNumArgs` is the only thing that prevents storing the arguments
in a trailing array. There is only 3
