[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

Eugene.Zelenko added a comment. I requested merge of updated documentation into 8.0 branch in PR40369. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54945/new/ https://reviews.llvm.org/D54945 ___ cfe-commits mailing l

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

Eugene.Zelenko added a comment. I fixed links. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54945/new/ https://reviews.llvm.org/D54945 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

Eugene.Zelenko added a comment. By the word, I noticed that HTTP was used and replaced it with HTTPS in Contributing.rst. Will be good idea to do the same in other documentation. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54945/new/ https://reviews.llvm.org/D5

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

Eugene.Zelenko added a comment. clang-tools-sphinx-docs bot is failing because of: Warning, treated as error: /home/buildbot/llvm-build-dir/clang-tools-sphinx-docs/llvm/src/tools/clang/tools/extra/docs/clang-tidy/Contributing.rst:61: ERROR: Unknown target name: "how to setup tooling for llvm".

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

This revision was automatically updated to reflect the committed changes. Closed by commit rL351463: [Documentation] Add a chapter about Clang-tidy integrations. (authored by eugenezelenko, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.or

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

MarinaKalashina added a comment. @Eugene.Zelenko @alexfh Thank you! How should I proceed with the revision now? Do I get it right from https://llvm.org/docs/Phabricator.html#committing-a-change, that without commit access, I need to ask for committing the changes for me? CHANGES SINCE LAST A

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

Eugene.Zelenko added a comment. In D54945#1355920 , @MarinaKalashina wrote: > @Eugene.Zelenko > > > I would suggest to rename contribution to Contributing (see LLVM > > documentation) and integrations to Integrations. > > Sure, done. > > > Will be also g

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

MarinaKalashina added a comment. @Eugene.Zelenko > I would suggest to rename contribution to Contributing (see LLVM > documentation) and integrations to Integrations. Sure, done. > Will be also good idea to fix D55523 script > warnings. The script warns abou

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

MarinaKalashina updated this revision to Diff 181528. MarinaKalashina marked an inline comment as done. MarinaKalashina added a comment. files renamed: //contribution.rst// to //Contributing.rst//, // integrations.rst// to //Integrations.rst// CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

Eugene.Zelenko added a comment. I would suggest to rename //contribution// to //Contributing// (see LLVM documentation) and //integrations// to //Integrations//. Will be also good idea to fix D55523 script warnings. CHANGES SINCE LAST ACTION https://reviews

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Awesome! Thanks a lot ! LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54945/new/ https://reviews.llvm.org/D54945 ___ cfe-commits mail

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

MarinaKalashina updated this revision to Diff 181217. MarinaKalashina added a comment. restoring full content CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54945/new/ https://reviews.llvm.org/D54945 Files: docs/clang-tidy/contribution.rst docs/clang-tidy/index.rst docs/clang-tidy

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

MarinaKalashina updated this revision to Diff 181216. MarinaKalashina added a comment. integrations.rst - end of file new line CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54945/new/ https://reviews.llvm.org/D54945 Files: docs/clang-tidy/integrations.rst Index: docs/clang-tidy/int

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

Eugene.Zelenko added inline comments. Comment at: docs/clang-tidy/integrations.rst:118 +allows to use a custom :program:`clang-tidy` binary. \ No newline at end of file Please add newline. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54945/new/ https

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

MarinaKalashina added a comment. @alexfh Thank you, please see the updated structure. @Eugene.Zelenko Done, the only warnings I got were about the table rows width. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54945/new/ https://reviews.llvm.org/D54945 __

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

MarinaKalashina updated this revision to Diff 181018. MarinaKalashina added a comment. Extracting 'Getting Involved' and 'Clang-tidy integrations' to separate pages linked in See Also. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54945/new/ https://reviews.llvm.org/D54945 Files: do

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

alexfh added a comment. In D54945#1340528 , @MarinaKalashina wrote: > @alexfh Just for me to be sure, should there be the following structure in > http://clang.llvm.org/extra/index.html: ... Roughly like that. More specifically, I'd suggest to modify t

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

MarinaKalashina added a comment. @alexfh Just for me to be sure, should there be the following structure in http://clang.llvm.org/extra/index.html: Clang-Tidy The list of clang-tidy checks Using clang-tidy Suppressing Undesired Diagnostics Clang-tidy Integrated (separate page) Getting

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

alexfh added inline comments. Comment at: docs/clang-tidy/index.rst:262 + +Clang-tidy integrated +- So how about moving this chapter to a separate page and adding a link to it at the top of this document? While certainly useful, the informati

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

Eugene.Zelenko added a comment. Please run script from D55523 over your changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54945/new/ https://reviews.llvm.org/D54945 ___ cfe-commits mailing list cfe-co

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

MarinaKalashina added a comment. @ilya-biryukov Thank you for a quick response and sorry for so many iterations. I uploaded a full-context version; hopefully this time it's alright - on my side, it finally looks like a proper full-context diff. CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

MarinaKalashina updated this revision to Diff 178647. MarinaKalashina added a comment. Full-context patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54945/new/ https://reviews.llvm.org/D54945 Files: docs/clang-tidy/index.rst Index: docs/clang-tidy/index.rst ==

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

ilya-biryukov added a comment. Thanks for the update! We still need to solve the technicality here: could you please upload the diff with full context? See LLVM docs for an example on how this can be done with var

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

MarinaKalashina updated this revision to Diff 178623. MarinaKalashina set the repository for this revision to rCTE Clang Tools Extra. MarinaKalashina added a comment. Another attempt to update the patch with the following fixes: - empty line before 'Standalone tool' - table columns with '+/-' ali

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

ilya-biryukov added a comment. Maybe try to use Arcanist for uploading diffs? The web interface can be confusing at times, Arcanist is more reliable (LLVM docs have pointers to the Arcanist documentation to get st

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

alexfh added a comment. In D54945#1321301 , @alexfh wrote: > In D54945#1318343 , @MarinaKalashina > wrote: > > > @alexfh Thanks a lot for your patience and help. I've made another > > revision, now with the diff m

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

alexfh added a comment. In D54945#1318343 , @MarinaKalashina wrote: > @alexfh Thanks a lot for your patience and help. I've made another revision, > now with the diff made by 'git show HEAD -U99' to have the full context > availlable. I don't know

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

MarinaKalashina added a comment. @alexfh Thanks a lot for your patience and help. I've made another revision, now with the diff made by 'git show HEAD -U99' to have the full context availlable. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54945/new/ https://reviews.llvm.org/D5494

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

MarinaKalashina updated this revision to Diff 176601. MarinaKalashina added a comment. Full-context patch for the changes introduced in the previous commit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54945/new/ https://reviews.llvm.org/D54945 Files: docs/clang-tidy/index.rst Ind

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

alexfh added a comment. In D54945#1318283 , @MarinaKalashina wrote: > In D54945#1318278 , @alexfh wrote: > > > In D54945#1316251 , > > @MarinaKalashina wrote: > > > > > Fix

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

MarinaKalashina marked 4 inline comments as done. MarinaKalashina added a comment. In D54945#1318278 , @alexfh wrote: > In D54945#1316251 , @MarinaKalashina > wrote: > > > Fixes: > > > > - empty line before 'Standa

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

alexfh added a comment. In D54945#1316251 , @MarinaKalashina wrote: > Fixes: > > - empty line before 'Standalone tool' > - table columns with '+/-' aligned > - line width limited to 80 (except for the table) > > Additions: > - clang-tidy-vs plugin > - C

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

MarinaKalashina updated this revision to Diff 176328. MarinaKalashina added a comment. Fixes: - empty line before 'Standalone tool' - table columns with '+/-' aligned - line width limited to 80 (except for the table) Additions: - clang-tidy-vs plugin - Clangd in the intro, the table, and CLion'

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

Eugene.Zelenko added inline comments. Comment at: docs/clang-tidy/index.rst:304 +CLion_ 2017.2 and later `integrates clang-tidy`_ as an extension to the built-in code analyzer. +Inspections and applicable quick-fixes are performed on the fly, and checks can be configured in the

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

sammccall added a comment. In D54945#1309467 , @JonasToth wrote: > I like the overview, maybe a link to `clangd` here might help, as there is > currently a lot of effort of integrating `clang-tidy` into it. (@sammccall > WDYT?) This would be great! The

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

alexfh added a comment. Should this chapter be a separate page linked from index.md? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54945/new/ https://reviews.llvm.org/D54945 ___ cfe-commits mailing list

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

JonasToth added subscribers: sammccall, JonasToth. JonasToth added a comment. I like the overview, maybe a link to `clangd` here might help, as there is currently a lot of effort of integrating `clang-tidy` into it. (@sammccall WDYT?) Comment at: docs/clang-tidy/index.rst:23

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

MarinaKalashina created this revision. MarinaKalashina added a reviewer: asl. Herald added subscribers: cfe-commits, arphaman. Proposing changes to //clang-tools-extra/docs/clang-tidy/index.rst// 'Using clang-tidy' was split into 2 chapters: - 'Standalone tool' (the previous content of 'Using cl