[PATCH] D55057: [Headers] Make max_align_t match GCC's implementation.

jyknight added inline comments. Herald added a project: clang. Comment at: lib/Headers/__stddef_max_align_t.h:44 +#endif } max_align_t; #endif EricWF wrote: > rsmith wrote: > > I don't want to hold up the immediate fix in this patch for this, but... we > >

[PATCH] D55057: [Headers] Make max_align_t match GCC's implementation.

uweigand added a comment. As an aside, it would be nice if we had a test case that verifies the explicit values of alignof(max_align_t) on all supported platforms. This is an ABI property that should never change. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D55057: [Headers] Make max_align_t match GCC's implementation.

uweigand marked an inline comment as done. uweigand added inline comments. Comment at: lib/Headers/__stddef_max_align_t.h:40 __attribute__((__aligned__(__alignof__(long double; +#ifdef __i386__ + __float128 __clang_max_align_nonce3 uweigand wrote: >

[PATCH] D55057: [Headers] Make max_align_t match GCC's implementation.

uweigand added inline comments. Comment at: lib/Headers/__stddef_max_align_t.h:40 __attribute__((__aligned__(__alignof__(long double; +#ifdef __i386__ + __float128 __clang_max_align_nonce3 jyknight wrote: > EricWF wrote: > > uweigand wrote: > > >

[PATCH] D55057: [Headers] Make max_align_t match GCC's implementation.

jyknight added inline comments. Comment at: lib/Headers/__stddef_max_align_t.h:40 __attribute__((__aligned__(__alignof__(long double; +#ifdef __i386__ + __float128 __clang_max_align_nonce3 EricWF wrote: > uweigand wrote: > > jyknight wrote: > > >

[PATCH] D55057: [Headers] Make max_align_t match GCC's implementation.

uweigand added inline comments. Comment at: lib/Headers/__stddef_max_align_t.h:40 __attribute__((__aligned__(__alignof__(long double; +#ifdef __i386__ + __float128 __clang_max_align_nonce3 jyknight wrote: > uweigand wrote: > > jyknight wrote: > > >

[PATCH] D55057: [Headers] Make max_align_t match GCC's implementation.

EricWF marked 2 inline comments as done. EricWF added a comment. @jyknight wrote: > And then use that to determine whether to add float128 to the union? Note that `max_align_t` isn't a union of these types, but a struct containing all of them. This seems like a bug to me, but it's what GNU

[PATCH] D55057: [Headers] Make max_align_t match GCC's implementation.

jyknight added inline comments. Comment at: lib/Headers/__stddef_max_align_t.h:40 __attribute__((__aligned__(__alignof__(long double; +#ifdef __i386__ + __float128 __clang_max_align_nonce3 uweigand wrote: > jyknight wrote: > > Can you fix clang to

[PATCH] D55057: [Headers] Make max_align_t match GCC's implementation.

rsmith added inline comments. Comment at: lib/Headers/__stddef_max_align_t.h:44 +#endif } max_align_t; #endif I don't want to hold up the immediate fix in this patch for this, but... we should move the definition of this type from the header into clang

[PATCH] D55057: [Headers] Make max_align_t match GCC's implementation.

uweigand added inline comments. Comment at: lib/Headers/__stddef_max_align_t.h:40 __attribute__((__aligned__(__alignof__(long double; +#ifdef __i386__ + __float128 __clang_max_align_nonce3 jyknight wrote: > Can you fix clang to consistently define

[PATCH] D55057: [Headers] Make max_align_t match GCC's implementation.

jyknight added inline comments. Comment at: lib/Headers/__stddef_max_align_t.h:40 __attribute__((__aligned__(__alignof__(long double; +#ifdef __i386__ + __float128 __clang_max_align_nonce3 Can you fix clang to consistently define

[PATCH] D55057: [Headers] Make max_align_t match GCC's implementation.

EricWF created this revision. EricWF added reviewers: rsmith, jyknight. GCC also considers the `__float128` type when constructing `max_align_t`. Clang's definition is intended to exactly match GCC's, so this patch make Clang do the same. NOTE: This breaks the ABI of `max_align_t` by changing