ioeric created this revision.
ioeric added a reviewer: kadircet.
Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay,
ilya-biryukov.
E.g. allow injected "A::A" in `using A::A^` but not in "A^".
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D55065
Files:
clangd/
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
Comment at: unittests/clangd/CodeCompleteTests.cpp:419
+TEST(CompletionTest, SkipInjectedWhenUnqualified) {
+ EXPECT_THAT(completions("struct X { void f(
ioeric marked an inline comment as done.
ioeric added inline comments.
Comment at: unittests/clangd/CodeCompleteTests.cpp:419
+TEST(CompletionTest, SkipInjectedWhenUnqualified) {
+ EXPECT_THAT(completions("struct X { void f() { X^ }};").Completions,
kadircet w
kadircet added inline comments.
Comment at: unittests/clangd/CodeCompleteTests.cpp:419
+TEST(CompletionTest, SkipInjectedWhenUnqualified) {
+ EXPECT_THAT(completions("struct X { void f() { X^ }};").Completions,
ioeric wrote:
> kadircet wrote:
> > Could you als
This revision was automatically updated to reflect the committed changes.
Closed by commit rL347982: [clangd] Drop injected class name when class scope
is not explicitly specified. (authored by ioeric, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
CHANGES SINCE L
