This revision was automatically updated to reflect the committed changes.
Closed by commit rL348587: [CTU] Eliminate race condition in CTU lit tests
(authored by martong, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
martong updated this revision to Diff 176660.
martong added a comment.
- Use rm, mkdir and break long RUN lines
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55129/new/
https://reviews.llvm.org/D55129
Files:
test/Analysis/ctu-main.cpp
Index:
xazax.hun accepted this revision.
xazax.hun added a comment.
This revision is now accepted and ready to land.
After the review comment is resolved, the rest LGTM!
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55129/new/
https://reviews.llvm.org/D55129
a_sidorin added a comment.
Hi Gabor,
Yes, the `%T` variable is obsolete, but it looks like the Guide recommendations
are not entirely fulfilled.
Comment at: test/Analysis/ctu-main.cpp:1
-// RUN: mkdir -p %T/ctudir
-// RUN: %clang_cc1 -triple x86_64-pc-linux-gnu -emit-pch -o
martong created this revision.
martong added reviewers: xazax.hun, a_sidorin.
Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs.
We plan to introduce additional CTU related lit test. Since lit may run the
tests in parallel, it is not safe to use the same directory (%T)
