This revision was automatically updated to reflect the committed changes.
Closed by commit rL348130: [clangd] Get rid of AST matchers in CodeComplete,
NFC (authored by hokein, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://revie
hokein updated this revision to Diff 176370.
hokein marked an inline comment as done.
hokein added a comment.
Using break.
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55206/new/
https://reviews.llvm.org/D55206
Files:
clangd/CodeComplete.cpp
I
kadircet added inline comments.
Comment at: clangd/CodeComplete.cpp:1654
+default:
+ return false;
+};
nit: maybe just `break` in here
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55206/new/
https://r
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
LG
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55206/new/
https://reviews.llvm.org/D55206
__
hokein created this revision.
hokein added a reviewer: kadircet.
Herald added subscribers: arphaman, jkorous, MaskRay, ioeric, ilya-biryukov.
The isIndexedForCodeCompletion is called in the code patch of
SymbolCollector.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D55206
File
