This revision was automatically updated to reflect the committed changes.
Closed by commit rC350521: [CTU] Make loadExternalAST return with non nullptr
on success (authored by martong, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D55280?vs=176779=180479#toc
Repository:
a_sidorin accepted this revision.
a_sidorin added a comment.
This revision is now accepted and ready to land.
Hi Gabor,
Yes, this looks good. Thanks!
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55280/new/
https://reviews.llvm.org/D55280
martong added a comment.
Ping @a_sidorin Could you please take another look and consider my previous
comment?
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55280/new/
https://reviews.llvm.org/D55280
___
cfe-commits
martong added a comment.
Hi Aleksey,
The first version was indeed not correct. But, I think we handle that case with
the latest update (https://reviews.llvm.org/differential/diff/176779/). In
`loadExternalAST()` we have this right before the return:
if (!Unit)
return
a_sidorin requested changes to this revision.
a_sidorin added a comment.
This revision now requires changes to proceed.
Hi Gabor,
There is a code in getExternalAST:
std::unique_ptr LoadedUnit(ASTUnit::LoadFromASTFile(
ASTFileName, CI.getPCHContainerOperations()->getRawReader(),
martong marked an inline comment as done.
martong added inline comments.
Comment at: lib/CrossTU/CrossTranslationUnit.cpp:147
llvm::Expected
CrossTranslationUnitContext::getCrossTUDefinition(const FunctionDecl *FD,
balazske wrote:
> Szelethus wrote:
> >
