Re: [PATCH] D55377: Allow forwarding -fdebug-compilation-dir to cc1as

2018-12-10 Thread David Blaikie via cfe-commits
Would it be worth considering whether -fdebug-compilation-dir and -fdebug-prefix-map could be unified, perhaps by having a placeholder that could be used in -fdebug-prefix-map for the current directory? I guess they're low-maintenance enough that it's probably not, but figured I'd ask. On Thu,

[PATCH] D55377: Allow forwarding -fdebug-compilation-dir to cc1as

2018-12-06 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL348515: Allow forwarding -fdebug-compilation-dir to cc1as (authored by nico, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D55377: Allow forwarding -fdebug-compilation-dir to cc1as

2018-12-06 Thread Hans Wennborg via Phabricator via cfe-commits
hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55377/new/ https://reviews.llvm.org/D55377 ___ cfe-commits mailing list

[PATCH] D55377: Allow forwarding -fdebug-compilation-dir to cc1as

2018-12-06 Thread Nico Weber via Phabricator via cfe-commits
thakis created this revision. thakis added a reviewer: rnk. The flag -fdebug-compilation-dir is useful to make generated .o files independent of the path of the build directory, without making the compile command-line dependent on the path of the build directory, like -fdebug-prefix-map