[PATCH] D55424: [analyzer] Supply all checkers with a shouldRegister function

2019-01-26 Thread Kristóf Umann via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC352277: [analyzer] Supply all checkers with a shouldRegister function (authored by Szelethus, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55424/new/ http

[PATCH] D55424: [analyzer] Supply all checkers with a shouldRegister function

2019-01-26 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a comment. In D55424#1364696 , @Szelethus wrote: > In D55424#1326397 , @NoQ wrote: > > > Should we also pass `CheckerManager` into `shouldRegister...`? Or is it > > entirely useless? > > > I wouldn'

[PATCH] D55424: [analyzer] Supply all checkers with a shouldRegister function

2019-01-20 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus updated this revision to Diff 182721. Szelethus added a comment. Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55424/new/ https://reviews.llvm.org/D55424 Files: include/clang/StaticAnalyzer/Checkers/BuiltinCheckerRegistration.h include/clang/StaticAnalyzer/Core/Ch

[PATCH] D55424: [analyzer] Supply all checkers with a shouldRegister function

2019-01-20 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a comment. In D55424#1326397 , @NoQ wrote: > Should we also pass `CheckerManager` into `shouldRegister...`? Or is it > entirely useless? I wouldn't say useless, but I'm struggling to come up with an example where registering would depen

[PATCH] D55424: [analyzer] Supply all checkers with a shouldRegister function

2018-12-10 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. Should we also pass `CheckerManager` into `shouldRegister...`? Or is it entirely useless? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55424/new/ https://reviews.llvm.org/D55424 ___ cfe-commits

[PATCH] D55424: [analyzer] Supply all checkers with a shouldRegister function

2018-12-07 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ accepted this revision. NoQ added a comment. Yeah, this part looks easy :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55424/new/ https://reviews.llvm.org/D55424 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D55424: [analyzer] Supply all checkers with a shouldRegister function

2018-12-07 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a comment. The checker file changes in this patch are pretty boring, here are those that don't always return true in `shouldRegister`: - `CastSizeChecker` - `GTestChecker` - `NSAutoreleasePoolChecker` - `ObjCAtSyncChecker` Repository: rC Clang CHANGES SINCE LAST ACTION htt

[PATCH] D55424: [analyzer] Supply all checkers with a shouldRegister function

2018-12-07 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus created this revision. Szelethus added reviewers: NoQ, george.karpenkov, xazax.hun, MTC, martong. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, jfb, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, whisperity. Herald added a reviewer: teemperor. S