This revision was automatically updated to reflect the committed changes.
Closed by commit rC350958: Implement Attr dumping in terms of visitors
(authored by steveire, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D55492?vs=181182&id=181334#toc
Repository:
rC Clang
CHANG
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
Comment at: lib/AST/ASTDumper.cpp:89
// Utilities
-void dumpType(QualType T) { NodeDumper.dumpType(T); }
void dumpTypeAsChild(QualType T);
-
steveire marked an inline comment as done.
steveire added inline comments.
Comment at: lib/AST/TextNodeDumper.cpp:44-45
+void TextNodeDumper::Visit(const Attr *A) {
+ {
+ColorScope Color(OS, ShowColors, AttrColor);
aaron.ballman wrote:
> Formatting is inco
steveire updated this revision to Diff 181182.
steveire marked an inline comment as done.
steveire added a comment.
Nits
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55492/new/
https://reviews.llvm.org/D55492
Files:
include/clang/AST/AttrVisitor.h
include/c
steveire added inline comments.
Comment at: lib/AST/ASTDumper.cpp:89
// Utilities
-void dumpType(QualType T) { NodeDumper.dumpType(T); }
void dumpTypeAsChild(QualType T);
aaron.ballman wrote:
> This seems unrelated to this patch (same below) ?
These
aaron.ballman added inline comments.
Comment at: include/clang/AST/TextNodeDumper.h:187
+
+// Implements Visit methods for Attrs
+#include "clang/AST/AttrTextNodeDump.inc"
Add a full stop to the end of the comment.
Comment at: lib/AST/ASTDumper
steveire marked an inline comment as done.
steveire added inline comments.
Comment at: utils/TableGen/ClangAttrEmitter.cpp:3726
+functionContent = SS.str();
+if (SS.tell()) {
+ OS << " void Visit" << R.getName() << "Attr(const " << R.getName()
aaron
steveire updated this revision to Diff 180943.
steveire added a comment.
Updates
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55492/new/
https://reviews.llvm.org/D55492
Files:
include/clang/AST/AttrVisitor.h
include/clang/AST/CMakeLists.txt
include/clang/
aaron.ballman added inline comments.
Comment at: include/clang/AST/AttrVisitor.h:23-24
+
+template struct make_ptr { using type = T *; };
+template struct make_const_ptr { using type = const T *; };
+
aaron.ballman wrote:
> steveire wrote:
> > aaron.ballman wro
aaron.ballman added inline comments.
Comment at: include/clang/AST/AttrVisitor.h:21
+
+namespace attrvisitor {
+
steveire wrote:
> aaron.ballman wrote:
> > I don't think the namespace adds value.
> I think the point is to separate the implementation detail. I don
steveire marked 3 inline comments as done.
steveire added inline comments.
Comment at: include/clang/AST/AttrVisitor.h:21
+
+namespace attrvisitor {
+
aaron.ballman wrote:
> I don't think the namespace adds value.
I think the point is to separate the implementati
aaron.ballman added inline comments.
Comment at: include/clang/AST/AttrVisitor.h:21
+
+namespace attrvisitor {
+
I don't think the namespace adds value.
Comment at: include/clang/AST/AttrVisitor.h:23-24
+
+template struct make_ptr { using type
steveire created this revision.
steveire added a reviewer: aaron.ballman.
Herald added subscribers: cfe-commits, mgorny.
Repository:
rC Clang
https://reviews.llvm.org/D55492
Files:
include/clang/AST/AttrVisitor.h
include/clang/AST/CMakeLists.txt
include/clang/AST/TextNodeDumper.h
lib/A
13 matches
Mail list logo
