[PATCH] D55640: [clang-tidy] Implement a check for large Objective-C type encodings 

thakis added a comment. FYI D96816 made clang emit way smaller encodings by default CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55640/new/ https://reviews.llvm.org/D55640 ___ cfe-commits mailing list

[PATCH] D55640: [clang-tidy] Implement a check for large Objective-C type encodings 

stephanemoore planned changes to this revision. stephanemoore added a comment. Reiterating outstanding action items: • Evaluate using hasDeclContext instead of hasAncestor. • Include type encoding size information in diagnostic messages. I've been observing some unexpected behaviors with

[PATCH] D55640: [clang-tidy] Implement a check for large Objective-C type encodings 

stephanemoore added a comment. In D55640#1329390 , @theraven wrote: > I wonder if we want to have an option to elide ObjC type info for all non-POD > C++ types. Nothing that you do with the type encoding is likely to be > correct (for example, you can

[PATCH] D55640: [clang-tidy] Implement a check for large Objective-C type encodings 

stephanemoore updated this revision to Diff 179239. stephanemoore marked 6 inline comments as done. stephanemoore added a comment. Changes: • Assert on `EncodedDecl`. • Mention default value in objc-type-encoding-size check notes. Outstanding action items: • Evaluate using `hasDeclContext`

[PATCH] D55640: [clang-tidy] Implement a check for large Objective-C type encodings 

hokein added inline comments. Comment at: clang-tidy/objc/TypeEncodingSizeCheck.cpp:36 + objcPropertyDecl(unless(isExpansionInSystemHeader()), + anyOf(hasAncestor(objcInterfaceDecl().bind("interface")), +

[PATCH] D55640: [clang-tidy] Implement a check for large Objective-C type encodings 

dmaclach added inline comments. Comment at: clang-tidy/objc/TypeEncodingSizeCheck.cpp:53 +diag(Block->getCaretLocation(), + "Objective-C type encoding for block expression exceeds %0 " + "characters") I found it very useful in my diagnostics

[PATCH] D55640: [clang-tidy] Implement a check for large Objective-C type encodings 

stephanemoore updated this revision to Diff 178152. stephanemoore added a comment. Update check description to match release notes. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55640/new/ https://reviews.llvm.org/D55640 Files:

[PATCH] D55640: [clang-tidy] Implement a check for large Objective-C type encodings 

Eugene.Zelenko added inline comments. Comment at: docs/clang-tidy/checks/objc-type-encoding-size.rst:6 + +Finds Objective-C type encodings that exceed a configured threshold. + Please synchronize with Release Notes. Repository: rCTE Clang Tools Extra

[PATCH] D55640: [clang-tidy] Implement a check for large Objective-C type encodings 

theraven added a comment. I wonder if we want to have an option to elide ObjC type info for all non-POD C++ types. Nothing that you do with the type encoding is likely to be correct (for example, you can see the pointer field in a `std::shared_ptr`, but you can't see that changes to it need

[PATCH] D55640: [clang-tidy] Implement a check for large Objective-C type encodings 

stephanemoore created this revision. Herald added subscribers: cfe-commits, jfb, xazax.hun, mgorny. Objective-C type encodings are normally pretty small but they it is pretty easy for them to bloat to undesirable levels. Bloated Objective-C type encodings are particularly common for Objective-C