This revision was automatically updated to reflect the committed changes.
Closed by commit rC349053: [CodeComplete] Fill preferred type on binary
expressions (authored by ibiryukov, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D55648?vs=178071&id=178072#toc
Repository:
r
ilya-biryukov updated this revision to Diff 178071.
ilya-biryukov added a comment.
Herald added a subscriber: arphaman.
- Update the test after changes
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55648/new/
https://reviews.llvm.org/D55648
Files:
include/clan
kadircet added inline comments.
Comment at: lib/Sema/SemaCodeComplete.cpp:4928
+if (LHSType->isIntegralOrEnumerationType())
+ return S.getASTContext().IntTy;
+return QualType();
ilya-biryukov wrote:
> kadircet wrote:
> > why not LHSType ?
> The shift
ilya-biryukov added a comment.
Thanks for the review!
Comment at: lib/Sema/SemaCodeComplete.cpp:4928
+if (LHSType->isIntegralOrEnumerationType())
+ return S.getASTContext().IntTy;
+return QualType();
kadircet wrote:
> why not LHSType ?
The shifts a
ilya-biryukov updated this revision to Diff 178069.
ilya-biryukov marked 4 inline comments as done.
ilya-biryukov added a comment.
- Address review comments
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55648/new/
https://reviews.llvm.org/D55648
Files:
include
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
It seems like we have some assumptions about what people might be trying to do
in most of the cases, but i think it is OK since this never performs worse than
the older version.
===
ilya-biryukov created this revision.
ilya-biryukov added a reviewer: kadircet.
Repository:
rC Clang
https://reviews.llvm.org/D55648
Files:
include/clang/Sema/Sema.h
lib/Parse/ParseExpr.cpp
lib/Sema/SemaCodeComplete.cpp
unittests/Sema/CodeCompleteTest.cpp
Index: unittests/Sema/CodeComp
