[PATCH] D55781: Make CC mangling conditional on the ABI version

rnk abandoned this revision. rnk added a comment. In D55781#1351541 , @rjmccall wrote: > Okay. In my opinion, then, we should just do this unconditionally. Sounds good to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55781/new/

[PATCH] D55781: Make CC mangling conditional on the ABI version

rjmccall added a comment. Okay. In my opinion, then, we should just do this unconditionally. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55781/new/ https://reviews.llvm.org/D55781 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D55781: Make CC mangling conditional on the ABI version

probinson added a comment. Herald added a subscriber: mstorsjo. Sorry for not noticing this sooner. The TL;DR is, the current patch does not affect PS4, so go ahead; but see the long version for other considerations. First, the general point: The PS4 ABI does not fit neatly into the sequential

[PATCH] D55781: Make CC mangling conditional on the ABI version

rjmccall added a reviewer: probinson. rjmccall added a comment. I think the core question is whether there are any vendors who care about ABI stability for these attributes who don't care about the bugfix. Speaking for Apple, we would rather have the bugfix. Sony might have different

[PATCH] D55781: Make CC mangling conditional on the ABI version

rnk added a comment. @rsmith asked if we should make this mangling conditional on the ABI version. I implemented it here, let me know if you think it's worth the extra code complexity. Our mingw ABI hasn't been particularly stable, but I think going forward we'll want to start mangling new

[PATCH] D55781: Make CC mangling conditional on the ABI version

rnk created this revision. rnk added reviewers: rjmccall, rsmith. Herald added a subscriber: krytarowski. https://reviews.llvm.org/D55781 Files: clang/lib/AST/ItaniumMangle.cpp clang/test/CodeGenCXX/mangle-win-ccs-old.cpp Index: clang/test/CodeGenCXX/mangle-win-ccs-old.cpp