[PATCH] D56090: Add a matcher for members of an initializer list expression

This revision was automatically updated to reflect the committed changes. Closed by commit rL350523: [clang] Add AST matcher for initializer list members (authored by hwright, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D56090?vs=18

[PATCH] D56090: Add a matcher for members of an initializer list expression

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Thanks, both! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56090/new/ https://reviews.llvm.org/D56090 ___ cfe-commi

[PATCH] D56090: Add a matcher for members of an initializer list expression

hwright marked 4 inline comments as done. hwright added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:3527 + return N < Node.getNumInits() && + InnerMatcher.matches(*Node.getInit(N)->IgnoreParenImpCasts(), Finder, + B

[PATCH] D56090: Add a matcher for members of an initializer list expression

hwright updated this revision to Diff 180248. hwright added a comment. Removed `IgnoreParenImpCasts` call. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56090/new/ https://reviews.llvm.org/D56090 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h lib

[PATCH] D56090: Add a matcher for members of an initializer list expression

klimek added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:3527 + return N < Node.getNumInits() && + InnerMatcher.matches(*Node.getInit(N)->IgnoreParenImpCasts(), Finder, + Builder); aaron.ballman wro

[PATCH] D56090: Add a matcher for members of an initializer list expression

aaron.ballman added a reviewer: klimek. aaron.ballman added a comment. Adding Manuel for the `hasArg()` questions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56090/new/ https://reviews.llvm.org/D56090 ___ cfe-commits mailing list cfe-com

[PATCH] D56090: Add a matcher for members of an initializer list expression

aaron.ballman added a subscriber: klimek. aaron.ballman added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:3527 + return N < Node.getNumInits() && + InnerMatcher.matches(*Node.getInit(N)->IgnoreParenImpCasts(), Finder, +

[PATCH] D56090: Add a matcher for members of an initializer list expression

hwright added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:3527 + return N < Node.getNumInits() && + InnerMatcher.matches(*Node.getInit(N)->IgnoreParenImpCasts(), Finder, + Builder); aaron.ballman wr

[PATCH] D56090: Add a matcher for members of an initializer list expression

hwright updated this revision to Diff 180089. hwright marked an inline comment as done. hwright added a comment. Added tests, update docs. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56090/new/ https://reviews.llvm.org/D56090 Files: docs/LibASTMatchersReference.html include/clang

[PATCH] D56090: Add a matcher for members of an initializer list expression

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. In D56090#1341023 , @hwright wrote: > @lebedev.ri Where do the appropriate tests live? (I couldn't find an obvious > subdirect

[PATCH] D56090: Add a matcher for members of an initializer list expression

hwright added a comment. @lebedev.ri Where do the appropriate tests live? (I couldn't find an obvious subdirectory in `test/`) Where are the instructions for regenerating the documentation? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56090/new/ https://review

[PATCH] D56090: Add a matcher for members of an initializer list expression

lebedev.ri added a comment. 1. Tests 2. The docs file will need to be regenerated Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56090/new/ https://reviews.llvm.org/D56090 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D56090: Add a matcher for members of an initializer list expression

hwright created this revision. hwright added a reviewer: aaron.ballman. hwright added a project: clang. Herald added a subscriber: cfe-commits. Much like `hasArg` for various call expressions, this allows `LibTooling` users to match against a member of an initializer list. This is currently bein