[PATCH] D56150: [sanitizer_common] Fix devname_r() return type on !NetBSD

2019-01-02 Thread Michał Górny via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL350228: [sanitizer_common] Fix devname_r() return type on !NetBSD (authored by mgorny, committed by ). Herald added a subscriber: delcypher. Changed prior to commit:

[PATCH] D56150: [sanitizer_common] Fix devname_r() return type on !NetBSD

2018-12-29 Thread Michał Górny via Phabricator via cfe-commits
mgorny updated this revision to Diff 179707. mgorny added a comment. Updated variable style. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56150/new/ https://reviews.llvm.org/D56150 Files: lib/sanitizer_common/sanitizer_common_interceptors.inc Index:

[PATCH] D56150: [sanitizer_common] Fix devname_r() return type on !NetBSD

2018-12-29 Thread Kamil Rytarowski via Phabricator via cfe-commits
krytarowski added a comment. Looks fine, but according to newer style of newer interceptors we prefer: `DEVNAME_R_RETTYPE res = REAL(devname_r)(dev, type, path, len);` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56150/new/ https://reviews.llvm.org/D56150

[PATCH] D56150: [sanitizer_common] Fix devname_r() return type on !NetBSD

2018-12-29 Thread Michał Górny via Phabricator via cfe-commits
mgorny updated this revision to Diff 179696. mgorny added a comment. Fixed lint. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56150/new/ https://reviews.llvm.org/D56150 Files: lib/sanitizer_common/sanitizer_common_interceptors.inc Index:

[PATCH] D56150: [sanitizer_common] Fix devname_r() return type on !NetBSD

2018-12-29 Thread Michał Górny via Phabricator via cfe-commits
mgorny created this revision. mgorny added reviewers: krytarowski, vitalybuka. Herald added subscribers: Sanitizers, llvm-commits, kubamracek, emaste. Update the interceptor for devname_r() to account for correct return types on different platforms. This function returns int on NetBSD but char*