[PATCH] D56152: [sanitizer_common] Add tests for remaining *putc and *getc variants

2018-12-29 Thread Kamil Rytarowski via Phabricator via cfe-commits
krytarowski accepted this revision. krytarowski added a comment. This revision is now accepted and ready to land. In D56152#1342372 , @mgorny wrote: > In D56152#1342331 , @krytarowski > wrote: > > > Are all the

[PATCH] D56152: [sanitizer_common] Add tests for remaining *putc and *getc variants

2018-12-29 Thread Michał Górny via Phabricator via cfe-commits
mgorny added a comment. In D56152#1342331 , @krytarowski wrote: > Are all the functions available for FreeBSD, NetBSD, Linux, Android, Solaris > an Darwin? I don't know. I suppose the easiest way to check would be to commit it and see what happens.

[PATCH] D56152: [sanitizer_common] Add tests for remaining *putc and *getc variants

2018-12-29 Thread Kamil Rytarowski via Phabricator via cfe-commits
krytarowski added a comment. Does this depend on D56109 ? It looks like we shall install interceptors for a lot of routines that are FILE* users. Repository: rCRT Compiler Runtime CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56152/new/

[PATCH] D56152: [sanitizer_common] Add tests for remaining *putc and *getc variants

2018-12-29 Thread Kamil Rytarowski via Phabricator via cfe-commits
krytarowski added a comment. Are all the functions available for FreeBSD, NetBSD, Linux, Android, Solaris an Darwin? I would include a test for `getchar_unlocked()` anyway, even if it's an alias in most/all implementations. Repository: rCRT Compiler Runtime CHANGES SINCE LAST ACTION

[PATCH] D56152: [sanitizer_common] Add tests for remaining *putc and *getc variants

2018-12-29 Thread Michał Górny via Phabricator via cfe-commits
mgorny created this revision. mgorny added reviewers: krytarowski, vitalybuka. Herald added subscribers: Sanitizers, llvm-commits, kubamracek. Subject: [PATCH 5/5] [sanitizer_common] Add tests for remaining *putc and *getc variants Add tests for the remaining character-oriented functions, that