This revision was automatically updated to reflect the committed changes.
Closed by commit rL350230: [sanitizer_common] Add test for popen() (authored by
mgorny, committed by ).
Herald added a subscriber: delcypher.
Changed prior to commit:
https://reviews.llvm.org/D56153?vs=179712&id=179870#to
mgorny updated this revision to Diff 179712.
mgorny added a comment.
Added assertion verifying that `fileno(fp)` works.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56153/new/
https://reviews.llvm.org/D56153
Files:
test/sanitizer_common/TestCases/Posix/popen.cc
Index: test/sanitiz
krytarowski accepted this revision.
krytarowski added a comment.
This revision is now accepted and ready to land.
But of course new code can be added as a new revision.
Repository:
rCRT Compiler Runtime
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56153/new/
https://reviews.llvm.org
krytarowski added a comment.
It looks fine, but we don't have interceptors for popen(3), popenve(3),
pclose(3). Could you include them together with this patch? Add add a test for
popenve(3).
Repository:
rCRT Compiler Runtime
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56153/new/
mgorny created this revision.
mgorny added reviewers: krytarowski, vitalybuka.
Herald added subscribers: Sanitizers, llvm-commits, kubamracek.
Repository:
rCRT Compiler Runtime
https://reviews.llvm.org/D56153
Files:
test/sanitizer_common/TestCases/Posix/popen.cc
Index: test/sanitizer_commo
