[PATCH] D56188: Adopt SwiftABIInfo for WebAssembly.

This revision was automatically updated to reflect the committed changes. Closed by commit rC350372: Adopt SwiftABIInfo for WebAssembly. (authored by ddunbar, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56188/new/ https://reviews.llvm.org/D56188

[PATCH] D56188: Adopt SwiftABIInfo for WebAssembly.

rjmccall added a comment. I don't mind you committing it like this. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56188/new/ https://reviews.llvm.org/D56188 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D56188: Adopt SwiftABIInfo for WebAssembly.

ddunbar added a comment. In D56188#1343667 , @rjmccall wrote: > ...although it might be reasonable to extract the method implementations on > `DefaultABIInfo` as helper functions so that the code can be reused without > requiring a particular

[PATCH] D56188: Adopt SwiftABIInfo for WebAssembly.

rjmccall added a comment. ...although it might be reasonable to extract the method implementations on `DefaultABIInfo` as helper functions so that the code can be reused without requiring a particular inheritance hierarchy. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D56188: Adopt SwiftABIInfo for WebAssembly.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56188/new/ https://reviews.llvm.org/D56188 ___

[PATCH] D56188: Adopt SwiftABIInfo for WebAssembly.

ddunbar created this revision. ddunbar added reviewers: rjmccall, sunfish. Herald added subscribers: cfe-commits, aheejin, jgravelle-google, sbc100, dschuff. - This adopts SwiftABIInfo as the base class for WebAssemblyABIInfo, which is in keeping with what is done for other targets for which