[PATCH] D56241: expose a control flag for interger to pointer ext warning

kristina added a comment. Going to test and land it as requested by @lebedev.ri on IRC. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56241/new/ https://reviews.llvm.org/D56241 ___ cfe-commits mailing list

[PATCH] D56241: expose a control flag for interger to pointer ext warning

Kader added a comment. friendly ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56241/new/ https://reviews.llvm.org/D56241 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D56241: expose a control flag for interger to pointer ext warning

Kader marked an inline comment as done. Kader added a comment. @lebedev.ri Thanks. I think do not have commit access. What should be my next step ? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56241/new/ https://reviews.llvm.org/D56241

[PATCH] D56241: expose a control flag for interger to pointer ext warning

lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. ok, LGTM. Comment at: test/Sema/ext-typecheck-comparison-of-pointer-integer.c:1 +// RUN: %clang_cc1 -triple x86_64-apple-darwin -fsyntax-only -verify

[PATCH] D56241: expose a control flag for interger to pointer ext warning

Kader marked 2 inline comments as done. Kader added inline comments. Comment at: test/Sema/ext-typecheck-comparison-of-pointer-integer.c:1 +// RUN: %clang_cc1 -triple x86_64-apple-darwin -fsyntax-only -verify -Wpointer-integer-compare %s + lebedev.ri wrote: >

[PATCH] D56241: expose a control flag for interger to pointer ext warning

Kader updated this revision to Diff 180143. Kader added a comment. remove typo Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56241/new/ https://reviews.llvm.org/D56241 Files: include/clang/Basic/DiagnosticSemaKinds.td test/Misc/warning-flags.c

[PATCH] D56241: expose a control flag for interger to pointer ext warning

Kader updated this revision to Diff 180142. Kader added a comment. address comments Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56241/new/ https://reviews.llvm.org/D56241 Files: include/clang/Basic/DiagnosticSemaKinds.td test/Misc/warning-flags.c

[PATCH] D56241: expose a control flag for interger to pointer ext warning

lebedev.ri added inline comments. Comment at: test/Sema/ext-typecheck-comparison-of-pointer-integer.c:1 +// RUN: %clang_cc1 -triple x86_64-apple-darwin -fsyntax-only -verify -Wpointer-integer-compare %s + I guess you want a run-line with no flag, this

[PATCH] D56241: expose a control flag for interger to pointer ext warning

Kader updated this revision to Diff 180125. Kader added a comment. added missing test file Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56241/new/ https://reviews.llvm.org/D56241 Files: include/clang/Basic/DiagnosticSemaKinds.td test/Misc/warning-flags.c

[PATCH] D56241: expose a control flag for interger to pointer ext warning

Kader added a comment. @lebedev.ri Thanks for the quick review ; > Perhaps there should be a test for this flag specifically? I am not really familiar with this part of the code base, but it seems that the warnings is already tested in both test/Sema/Compare.c and test/SemaCXX/compare.cpp. I

[PATCH] D56241: expose a control flag for interger to pointer ext warning

Kader updated this revision to Diff 180124. Kader added a comment. Added test case for C_lang Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56241/new/ https://reviews.llvm.org/D56241 Files: include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D56241: expose a control flag for interger to pointer ext warning

lebedev.ri added a comment. Looks ok in general. Perhaps there should be a test for this flag specifically? Also, should "pointer-integer-compare" be in some group? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56241/new/ https://reviews.llvm.org/D56241

[PATCH] D56241: expose a control flag for interger to pointer ext warning

Kader created this revision. Kader added a project: clang. Herald added a subscriber: cfe-commits. While building openJDK11u, it seems that some of the code in the native core libraries make liberal use of integer to pointer comparisons. We currently have no flag to disabled this warning. This