serge-sans-paille accepted this revision.
serge-sans-paille added a comment.
This revision is now accepted and ready to land.
Sorry for the long delay, this LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56343/new/
https://reviews.llvm.org/D56343
_
JonasToth added a comment.
From my side its LGTM, but I would let @serge-sans-paille accept, as he is
probably more familiar with python then I am.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56343/new/
https://reviews.llvm.org/D56343
__
LegalizeAdulthood marked 9 inline comments as done.
LegalizeAdulthood added inline comments.
Comment at: test/clang-tidy/check_clang_tidy.py:112
+process_output = e.output.decode()
+print('%s failed:\n%s' % (' '.join(args), process_output))
+if raise_error:
--
LegalizeAdulthood updated this revision to Diff 396909.
LegalizeAdulthood marked 4 inline comments as done.
LegalizeAdulthood edited the summary of this revision.
LegalizeAdulthood set the repository for this revision to rG LLVM Github
Monorepo.
LegalizeAdulthood added a comment.
Rebase on top of
LegalizeAdulthood added a comment.
This was accepted before in August, 2019, but the script changed in the
meantime. I've repeated the Extract Class on top-of-tree,
so presumably this is still acceptable. However, I don't know how commit
access has changed. (I don't think I have it anymore.)
LegalizeAdulthood added a comment.
If there are no new comments by the end of the week, I'm going to accept this
revision and commit it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56343/new/
https://reviews.llvm.org/D56343
aaron.ballman resigned from this revision.
aaron.ballman added a comment.
Resigning only because I don't think I have strong enough Python skills to give
a quality review. I didn't spot anything that concerned me specific to this
patch though.
Repository:
rG LLVM Github Monorepo
CHANGES SIN
This revision was automatically updated to reflect the committed changes.
Closed by commit rGa2c33b0ec976: [clang-tidy] Refactor: Extract Class
CheckRunner on check_clang_tidy.py (authored by LegalizeAdulthood).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.ll
