[PATCH] D56405: Split -Wdelete-non-virtual-dtor into two groups

This revision was automatically updated to reflect the committed changes. Closed by commit rC350856: Split -Wdelete-non-virtual-dtor into two groups (authored by epilk, committed by ). Changed prior to commit: https://reviews.llvm.org/D56405?vs=180690&id=181081#toc Repository: rC Clang CHAN

[PATCH] D56405: Split -Wdelete-non-virtual-dtor into two groups

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56405/new/ https://reviews.llvm.org/D56405 ___ cfe-commits mailing lis

[PATCH] D56405: Split -Wdelete-non-virtual-dtor into two groups

erik.pilkington updated this revision to Diff 180690. erik.pilkington added a comment. This revision is now accepted and ready to land. Split -Wdelete-non-virtual-dtor into -Wdelete-non-abstract-non-virtual-dtor and -Wdelete-abstract-non-virtual-dtor. CHANGES SINCE LAST ACTION https://reviews

[PATCH] D56405: Split -Wdelete-non-virtual-dtor into two groups

erik.pilkington reopened this revision. erik.pilkington marked an inline comment as done. erik.pilkington added a comment. This revision is now accepted and ready to land. I reverted my commit in r350639. Comment at: include/clang/Basic/DiagnosticGroups.td:108-109 def DeleteNo

[PATCH] D56405: Split -Wdelete-non-virtual-dtor into two groups

aaron.ballman added inline comments. Comment at: include/clang/Basic/DiagnosticGroups.td:108-109 def DeleteNonVirtualDtor : DiagGroup<"delete-non-virtual-dtor">; +def DeleteAbstractNonVirtualDtor : DiagGroup<"delete-abstract-non-virtual-dtor", +

[PATCH] D56405: Split -Wdelete-non-virtual-dtor into two groups

rsmith added inline comments. Comment at: include/clang/Basic/DiagnosticGroups.td:108-109 def DeleteNonVirtualDtor : DiagGroup<"delete-non-virtual-dtor">; +def DeleteAbstractNonVirtualDtor : DiagGroup<"delete-abstract-non-virtual-dtor", +

[PATCH] D56405: Split -Wdelete-non-virtual-dtor into two groups

aaron.ballman added inline comments. Comment at: include/clang/Basic/DiagnosticGroups.td:108-109 def DeleteNonVirtualDtor : DiagGroup<"delete-non-virtual-dtor">; +def DeleteAbstractNonVirtualDtor : DiagGroup<"delete-abstract-non-virtual-dtor", +

[PATCH] D56405: Split -Wdelete-non-virtual-dtor into two groups

rsmith added inline comments. Comment at: include/clang/Basic/DiagnosticGroups.td:108-109 def DeleteNonVirtualDtor : DiagGroup<"delete-non-virtual-dtor">; +def DeleteAbstractNonVirtualDtor : DiagGroup<"delete-abstract-non-virtual-dtor", +

[PATCH] D56405: Split -Wdelete-non-virtual-dtor into two groups

This revision was automatically updated to reflect the committed changes. Closed by commit rC350585: Split -Wdelete-non-virtual-dtor into -Wdelete-abstract-non-virtual-dtor (authored by epilk, committed by ). Changed prior to commit: https://reviews.llvm.org/D56405?vs=180532&id=180584#toc Repo

[PATCH] D56405: Split -Wdelete-non-virtual-dtor into two groups

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56405/new/ https://reviews.llvm.org/D56405 ___

[PATCH] D56405: Split -Wdelete-non-virtual-dtor into two groups

erik.pilkington created this revision. erik.pilkington added reviewers: rsmith, aaron.ballman. Herald added subscribers: dexonsmith, jkorous. `-Wdelete-non-virtual-dtor` controlled two diagnostics: 1) calling a non-virtual dtor from an abstract class, and 2) calling a non-virtual dtor from a pol