[PATCH] D56429: fix python3 compability issue

serge-sans-paille added a comment. Thanks @roxma for the patch! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56429/new/ https://reviews.llvm.org/D56429 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D56429: fix python3 compability issue

This revision was automatically updated to reflect the committed changes. Closed by commit rL352039: Fix python3 compability issue in clang binding (authored by serge_sans_paille, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D56429: fix python3 compability issue

roxma added a comment. Yes please. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56429/new/ https://reviews.llvm.org/D56429 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D56429: fix python3 compability issue

serge-sans-paille added a comment. @roxma: do you want me to commit this on your behalf? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56429/new/ https://reviews.llvm.org/D56429 ___ cfe-commits mailing list

[PATCH] D56429: fix python3 compability issue

serge-sans-paille accepted this revision. serge-sans-paille added inline comments. This revision is now accepted and ready to land. Comment at: bindings/python/clang/cindex.py:2998 +for i,(name,contents) in enumerate(unsaved_files): +if

[PATCH] D56429: fix python3 compability issue

jstasiak marked an inline comment as done. jstasiak added inline comments. Comment at: bindings/python/clang/cindex.py:3001 +contents = b(contents) +unsaved_files_array[i].name = b(fspath(name)) +unsaved_files_array[i].contents =

[PATCH] D56429: fix python3 compability issue

roxma marked an inline comment as done. roxma added inline comments. Comment at: bindings/python/clang/cindex.py:2998 +for i,(name,contents) in enumerate(unsaved_files): +if hasattr(contents, "read"): +contents = contents.read()

[PATCH] D56429: fix python3 compability issue

serge-sans-paille added inline comments. Comment at: bindings/python/clang/cindex.py:2998 +for i,(name,contents) in enumerate(unsaved_files): +if hasattr(contents, "read"): +contents = contents.read()

[PATCH] D56429: fix python3 compability issue

serge-sans-paille added inline comments. Comment at: bindings/python/clang/cindex.py:2998 +for i,(name,contents) in enumerate(unsaved_files): +if hasattr(contents, "read"): +contents = contents.read() Why did you

[PATCH] D56429: fix python3 compability issue

roxma created this revision. roxma added reviewers: ilya-biryukov, mgorny. Herald added subscribers: cfe-commits, arphaman. Herald added a reviewer: serge-sans-paille. The file contents could be of str type. Should use byte length instead of str length, otherwise utf-8 encoded files may not get