[PATCH] D56532: [clang-tidy] Add the abseil-duration-conversion-cast check

This revision was automatically updated to reflect the committed changes. Closed by commit rL351473: [clang-tidy] Add abseil-duration-conversion-cast check (authored by hwright, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D56532: [clang-tidy] Add the abseil-duration-conversion-cast check

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56532/new/ https://reviews.llvm.org/D56532 ___ cfe-commits mailing

[PATCH] D56532: [clang-tidy] Add the abseil-duration-conversion-cast check

hwright updated this revision to Diff 182043. hwright marked 6 inline comments as done. hwright added a comment. Address reviewer comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56532/new/ https://reviews.llvm.org/D56532 Files: clang-tidy/abseil/AbseilTidyModule.cpp

[PATCH] D56532: [clang-tidy] Add the abseil-duration-conversion-cast check

hwright added inline comments. Comment at: clang-tidy/abseil/DurationComparisonCheck.cpp:47-48 // if nothing needs to be done. - if (!IsValidMacro(Result, Binop->getLHS()) || - !IsValidMacro(Result, Binop->getRHS())) + if (!isNotInMacro(Result, Binop->getLHS()) || +

[PATCH] D56532: [clang-tidy] Add the abseil-duration-conversion-cast check

aaron.ballman added inline comments. Comment at: clang-tidy/abseil/DurationComparisonCheck.cpp:47-48 // if nothing needs to be done. - if (!IsValidMacro(Result, Binop->getLHS()) || - !IsValidMacro(Result, Binop->getRHS())) + if (!isNotInMacro(Result, Binop->getLHS())

[PATCH] D56532: [clang-tidy] Add the abseil-duration-conversion-cast check

hwright added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56532/new/ https://reviews.llvm.org/D56532 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D56532: [clang-tidy] Add the abseil-duration-conversion-cast check

hwright updated this revision to Diff 181204. hwright marked an inline comment as done. hwright added a comment. Run `clang-format` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56532/new/ https://reviews.llvm.org/D56532 Files: clang-tidy/abseil/AbseilTidyModule.cpp

[PATCH] D56532: [clang-tidy] Add the abseil-duration-conversion-cast check

Eugene.Zelenko added inline comments. Comment at: clang-tidy/abseil/DurationConversionCastCheck.cpp:41 + + if (!isNotInMacro(Result, MatchedCast)) return; + Please run Clang-format. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56532/new/

[PATCH] D56532: [clang-tidy] Add the abseil-duration-conversion-cast check

hwright updated this revision to Diff 181125. hwright marked 5 inline comments as done. hwright added a comment. Update documentation line wrapping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56532/new/ https://reviews.llvm.org/D56532 Files: clang-tidy/abseil/AbseilTidyModule.cpp

[PATCH] D56532: [clang-tidy] Add the abseil-duration-conversion-cast check

hwright added inline comments. Comment at: docs/clang-tidy/checks/abseil-duration-conversion-cast.rst:20 + + + // Original - Cast from a double to an integer MyDeveloperDay wrote: > nit: double blank line This is intentional (and consistent with other examples

[PATCH] D56532: [clang-tidy] Add the abseil-duration-conversion-cast check

MyDeveloperDay added a comment. nit's come from running running validate_check.py on the rst file from D55523: [clang-tidy] Linting .rst documentation $ ../clang-tidy/validate_check.py --rst abseil-duration-conversion-cast.rst Checking

[PATCH] D56532: [clang-tidy] Add the abseil-duration-conversion-cast check

hwright created this revision. hwright added reviewers: hokein, aaron.ballman. hwright added a project: clang-tools-extra. Herald added subscribers: cfe-commits, xazax.hun, mgorny. This suggests simplifying expressions which are casting conversion functions, such as