[PATCH] D56959: [AST] NFC: Introduce new class GenericSelectionExpr::Association

steveire abandoned this revision. steveire added a comment. An alternative was written and committed. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56959/new/ https://reviews.llvm.org/D56959 ___ cfe-commits mailing l

[PATCH] D56959: [AST] NFC: Introduce new class GenericSelectionExpr::Association

riccibruno added inline comments. Comment at: include/clang/AST/Expr.h:5068 + Association getAssociation(unsigned I) const { +return Association(cast(SubExprs[END_EXPR + I]), AssocTypes[I], riccibruno wrote: > aaron.ballman wrote: > > steveire wrote: > > >

[PATCH] D56959: [AST] NFC: Introduce new class GenericSelectionExpr::Association

riccibruno added a comment. Some small additional remarks if you are already modifying this class. Comment at: include/clang/AST/Expr.h:5021 unsigned NumAssocs, ResultIndex; SourceLocation GenericLoc, DefaultLoc, RParenLoc; It is possible to stuff one `

[PATCH] D56959: [AST] NFC: Introduce new class GenericSelectionExpr::Association

riccibruno added inline comments. Comment at: include/clang/AST/Expr.h:5068 + Association getAssociation(unsigned I) const { +return Association(cast(SubExprs[END_EXPR + I]), AssocTypes[I], aaron.ballman wrote: > steveire wrote: > > aaron.ballman wrote: >

[PATCH] D56959: [AST] NFC: Introduce new class GenericSelectionExpr::Association

aaron.ballman added inline comments. Comment at: include/clang/AST/Expr.h:5068 + Association getAssociation(unsigned I) const { +return Association(cast(SubExprs[END_EXPR + I]), AssocTypes[I], steveire wrote: > aaron.ballman wrote: > > steveire wrote: > >

[PATCH] D56959: [AST] NFC: Introduce new class GenericSelectionExpr::Association

steveire marked an inline comment as done. steveire added inline comments. Comment at: include/clang/AST/Expr.h:5068 + Association getAssociation(unsigned I) const { +return Association(cast(SubExprs[END_EXPR + I]), AssocTypes[I], aaron.ballman wrote: > st

[PATCH] D56959: [AST] NFC: Introduce new class GenericSelectionExpr::Association

aaron.ballman added inline comments. Comment at: include/clang/AST/Expr.h:5068 + Association getAssociation(unsigned I) const { +return Association(cast(SubExprs[END_EXPR + I]), AssocTypes[I], steveire wrote: > aaron.ballman wrote: > > Rather than gin thes

[PATCH] D56959: [AST] NFC: Introduce new class GenericSelectionExpr::Association

steveire marked 2 inline comments as done. steveire added inline comments. Comment at: include/clang/AST/Expr.h:5068 + Association getAssociation(unsigned I) const { +return Association(cast(SubExprs[END_EXPR + I]), AssocTypes[I], aaron.ballman wrote: > Ra

[PATCH] D56959: [AST] NFC: Introduce new class GenericSelectionExpr::Association

aaron.ballman added inline comments. Comment at: include/clang/AST/Expr.h:5068 + Association getAssociation(unsigned I) const { +return Association(cast(SubExprs[END_EXPR + I]), AssocTypes[I], Rather than gin these objects up on demand every time they're n

[PATCH] D56959: [AST] NFC: Introduce new class GenericSelectionExpr::Association

riccibruno added inline comments. Comment at: include/clang/AST/Expr.h:5020 Stmt **SubExprs; unsigned NumAssocs, ResultIndex; SourceLocation GenericLoc, DefaultLoc, RParenLoc; I know that this is not part of this patch, but these arrays are begging to be

[PATCH] D56959: [AST] NFC: Introduce new class GenericSelectionExpr::Association

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. As a type, this can be visited upon. This is similar in spirit to the BlockDecl::Capture type. Repository: rC Clang https://reviews.llvm.org/D56959 Files: include/clang/AST/Ex