[PATCH] D56984: [libunwind] Silence warnings about unused parameters

2019-01-22 Thread Martin Storsjö via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rUNW351888: Silence warnings about unused parameters (authored by mstorsjo, committed by ). Repository: rUNW libunwind CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56984/new/ https://reviews.ll

[PATCH] D56984: [libunwind] Silence warnings about unused parameters

2019-01-22 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added a comment. In D56984#1366297 , @ldionne wrote: > LGTM, but would it make sense to have a macro like > `_LIBUNWIND_MAYBE_UNUSED(var)` instead? I guess some macro like that could be ok as well, although I think the `(void)var` is a rather

[PATCH] D56984: [libunwind] Silence warnings about unused parameters

2019-01-22 Thread Louis Dionne via Phabricator via cfe-commits
ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. LGTM, but would it make sense to have a macro like `_LIBUNWIND_MAYBE_UNUSED(var)` instead? Repository: rUNW libunwind CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56984/new/ ht

[PATCH] D56984: [libunwind] Silence warnings about unused parameters

2019-01-20 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo created this revision. mstorsjo added reviewers: mclow.lists, EricWF, ldionne. Herald added a subscriber: libcxx-commits. Repository: rUNW libunwind https://reviews.llvm.org/D56984 Files: src/AddressSpace.hpp src/Unwind-seh.cpp src/UnwindCursor.hpp Index: src/UnwindCursor.hpp