[PATCH] D56989: [analyzer][NFC] Keep track of whether enabling a checker was explictly specified in command line arguments

2019-01-25 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Cool! I guess we still need to think how exactly do we want to resolve conflicts between dependencies. Comment at: include/clang/StaticAnalyzer/Frontend/CheckerRegistry.h:152 +

[PATCH] D56989: [analyzer][NFC] Keep track of whether enabling a checker was explictly specified in command line arguments

2019-01-26 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus marked an inline comment as done. Szelethus added inline comments. Comment at: lib/StaticAnalyzer/Frontend/CheckerRegistry.cpp:143 + // Would it be better to name it '~experimental' or something else + // that's ASCIIbetically last? + llvm::sort(Checkers, checkerName

[PATCH] D56989: [analyzer][NFC] Keep track of whether enabling a checker was explictly specified in command line arguments

2019-01-26 Thread Kristóf Umann via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL352282: [analyzer][NFC] Keep track of whether enabling a checker was explictly… (authored by Szelethus, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.

[PATCH] D56989: [analyzer][NFC] Keep track of whether enabling a checker was explictly specified in command line arguments

2019-01-26 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a comment. Oops, I ran into the issue of `check-clang-analysis` not actually running out unit tests. I decided not to revert this patch and just commit the fix: rC352284 . Any objections? Repository: rL LLVM CHANGES SINCE LAST ACTION http