[PATCH] D57054: [MachineOutliner][ARM][RFC] Add Machine Outliner support for ARM

yroux abandoned this revision. yroux added a comment. All patches are now committed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57054/new/ https://reviews.llvm.org/D57054 ___ cfe-commits mailing list

[PATCH] D57054: [MachineOutliner][ARM][RFC] Add Machine Outliner support for ARM

yroux marked an inline comment as done. yroux added inline comments. Comment at: llvm/lib/CodeGen/MachineOutliner.cpp:1159 + MF.getProperties().reset(MachineFunctionProperties::Property::IsSSA); + MF.getProperties().set(MachineFunctionProperties::Property::NoPHIs); +

[PATCH] D57054: [MachineOutliner][ARM][RFC] Add Machine Outliner support for ARM

yroux marked 2 inline comments as done. yroux added a comment. Thanks for the comments Sam, Thumb1 is disabled in this version (see inline comment). The is to bundle Machine Outliner to -Oz like it was done for AArch64, but here it just run when the flags are used (-moutline for clang or

[PATCH] D57054: [MachineOutliner][ARM][RFC] Add Machine Outliner support for ARM

samparker added a comment. How about removing Thumb-1 support until it's properly handled? I also suggest that this gets broken down a bit too, by handling the different types of function call in different patches, like getting tail-call support in first or something. Also, is this currently

[PATCH] D57054: [MachineOutliner][ARM][RFC] Add Machine Outliner support for ARM

yroux added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57054/new/ https://reviews.llvm.org/D57054 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D57054: [MachineOutliner][ARM][RFC] Add Machine Outliner support for ARM

yroux updated this revision to Diff 241188. yroux added a comment. Here is a new version, which disables ARM Low Overhead Loops pass when the Machine Outliner is enabled. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57054/new/

[PATCH] D57054: [MachineOutliner][ARM][RFC] Add Machine Outliner support for ARM

samparker added a comment. > Even if you only decrease the size you can have a distance increase due to > aligment constraints Ah... thanks for raising this. I'll look into it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57054/new/

[PATCH] D57054: [MachineOutliner][ARM][RFC] Add Machine Outliner support for ARM

yroux added a comment. > ! In D57054#1811740 , @samparker > wrote: > Hmm, would it be possible to pass a bool to the pass which will control > whether liveness is updated? The other, suboptimal, option would be to not do > outlining when we have the

[PATCH] D57054: [MachineOutliner][ARM][RFC] Add Machine Outliner support for ARM

samparker added a comment. > I can add liveness info into the outlined function, but we will need to do > the same on AArch64 even if is not necessary. Hmm, would it be possible to pass a bool to the pass which will control whether liveness is updated? The other, suboptimal, option would be to

[PATCH] D57054: [MachineOutliner][ARM][RFC] Add Machine Outliner support for ARM

yroux added a comment. In D57054#1811486 , @samparker wrote: > This, and the fact that LowOverheadLoops is dependent upon block sizes and > placement (I need to add a comment in the header on that pass). So, > ConstantIslands would have to guarantee

[PATCH] D57054: [MachineOutliner][ARM][RFC] Add Machine Outliner support for ARM

samparker added a comment. > It might be possible to rearrange Low Overhead Loops to run before > ConstantIslands, but you'd probably need to do more to make it work properly. > I don't think ConstantIslands knows how to handle the branches generated by > LowOverheadLoop. This, and the fact

[PATCH] D57054: [MachineOutliner][ARM][RFC] Add Machine Outliner support for ARM

yroux added a comment. Ah right, let's wait for Sam comments/advises and I'll prepare a proper patch for that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57054/new/ https://reviews.llvm.org/D57054

[PATCH] D57054: [MachineOutliner][ARM][RFC] Add Machine Outliner support for ARM

SjoerdMeijer added a subscriber: samparker. SjoerdMeijer added a comment. Just a quick message, linking in @samparker, and I guess moving Low Overhead Loops to run before ConstantIslands could be problematic, but we can/should have a proper look tomorrow. Repository: rG LLVM Github Monorepo

[PATCH] D57054: [MachineOutliner][ARM][RFC] Add Machine Outliner support for ARM

efriedma added a comment. It might be possible to rearrange Low Overhead Loops to run before ConstantIslands, but you'd probably need to do more to make it work properly. I don't think ConstantIslands knows how to handle the branches generated by LowOverheadLoop. If you think it's necessary,

[PATCH] D57054: [MachineOutliner][ARM][RFC] Add Machine Outliner support for ARM

yroux updated this revision to Diff 236838. yroux added a comment. Herald added subscribers: cfe-commits, hiraditya. Herald added a project: clang. Hi, here is an update for the Machine Outliner support on ARM targets. It addresses the comments received on the initial version and is rebased on