[PATCH] D57112: [ASTTypeTraits] OMPClause handling

lebedev.ri marked 6 inline comments as not done. lebedev.ri added inline comments. Comment at: lib/AST/ASTTypeTraits.cpp:114 +#define OPENMP_CLAUSE(Name, Class) \ +case OMPC_##Name: return ASTNodeKind(NKI_##Class); +#include

[PATCH] D57112: [ASTTypeTraits] OMPClause handling

gribozavr added a comment. > The test coverage i have will be in the clang-tidy check. Please add unit tests to `clang/unittests/ASTMatchers/ASTMatchersNodeTest.cpp`. You can pull matchers from D57113 into the shared matchers library (instead of keeping them

[PATCH] D57112: [ASTTypeTraits] OMPClause handling

lebedev.ri added a comment. ping @klimek @hokein thanks. The fun of of the code that is so well separated that no one touches it for years and thus can't review patches for it :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57112/new/

[PATCH] D57112: [ASTTypeTraits] OMPClause handling

lebedev.ri added a comment. Maybe ping @klimek then? :) In D57112#1400046 , @alexfh wrote: > In D57112#1399516 , @lebedev.ri > wrote: > > > Ping @hokein / @alexfh (as per git blame). > > Not sure who is best

[PATCH] D57112: [ASTTypeTraits] OMPClause handling

alexfh added a comment. In D57112#1399516 , @lebedev.ri wrote: > Ping @hokein / @alexfh (as per git blame). > Not sure who is best suited to review this. I only made a couple of random fixes to these files, so I don't feel particularly competent to

[PATCH] D57112: [ASTTypeTraits] OMPClause handling

lebedev.ri added a subscriber: alexfh. lebedev.ri added a comment. Herald added a subscriber: jdoerfert. Ping @hokein / @alexfh (as per git blame). Not sure who is best suited to review this. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57112/new/

[PATCH] D57112: [ASTTypeTraits] OMPClause handling

lebedev.ri added a comment. Herald added a project: clang. Ping. I'm not quite sure who is the best suited to review this.. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57112/new/ https://reviews.llvm.org/D57112

[PATCH] D57112: [ASTTypeTraits] OMPClause handling

lebedev.ri updated this revision to Diff 183902. lebedev.ri marked an inline comment as done. lebedev.ri added a comment. - Rebased - Go back to storing the actual AST class type as string in `ASTNodeKind::KindInfo ASTNodeKind::AllKindInfo[]`. - Add `OpenMPClauseKind

[PATCH] D57112: [ASTTypeTraits] OMPClause handling

lebedev.ri added inline comments. Comment at: lib/AST/ASTTypeTraits.cpp:40-43 + { NKI_None, "OMPClause" }, +#define OPENMP_CLAUSE(TextualSpelling, DERIVED) \ + {NKI_OMPClause, #TextualSpelling}, +#include "clang/Basic/OpenMPKinds.def"

[PATCH] D57112: [ASTTypeTraits] OMPClause handling

lebedev.ri updated this revision to Diff 183692. lebedev.ri added a comment. Store OpenMP clause spelling in the `ASTNodeKind::KindInfo ASTNodeKind::AllKindInfo[]`, not the stringified clang AST class name. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D57112: [ASTTypeTraits] OMPClause handling

lebedev.ri updated this revision to Diff 183690. lebedev.ri marked an inline comment as done. lebedev.ri added a comment. Rebased ontop of D57280 , use `const auto*`. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57112/new/

[PATCH] D57112: [ASTTypeTraits] OMPClause handling

lebedev.ri marked 5 inline comments as done. lebedev.ri added inline comments. Comment at: lib/AST/ASTTypeTraits.cpp:114 +#define OPENMP_CLAUSE(Name, Class) \ +case OMPC_##Name: return ASTNodeKind(NKI_##Class); +#include

[PATCH] D57112: [ASTTypeTraits] OMPClause handling

lebedev.ri marked an inline comment as done and an inline comment as not done. lebedev.ri added inline comments. Comment at: lib/AST/ASTTypeTraits.cpp:114 +#define OPENMP_CLAUSE(Name, Class) \ +case OMPC_##Name: return

[PATCH] D57112: [ASTTypeTraits] OMPClause handling

ABataev added inline comments. Comment at: lib/AST/ASTTypeTraits.cpp:114 +#define OPENMP_CLAUSE(Name, Class) \ +case OMPC_##Name: return ASTNodeKind(NKI_##Class); +#include "clang/Basic/OpenMPKinds.def" ABataev

[PATCH] D57112: [ASTTypeTraits] OMPClause handling

ABataev added inline comments. Comment at: lib/AST/ASTTypeTraits.cpp:114 +#define OPENMP_CLAUSE(Name, Class) \ +case OMPC_##Name: return ASTNodeKind(NKI_##Class); +#include "clang/Basic/OpenMPKinds.def" lebedev.ri

[PATCH] D57112: [ASTTypeTraits] OMPClause handling

lebedev.ri marked an inline comment as done. lebedev.ri added a comment. @ABataev Thank you for taking a look! Comment at: lib/AST/ASTTypeTraits.cpp:114 +#define OPENMP_CLAUSE(Name, Class) \ +case OMPC_##Name: return

[PATCH] D57112: [ASTTypeTraits] OMPClause handling

ABataev added inline comments. Comment at: lib/AST/ASTTypeTraits.cpp:114 +#define OPENMP_CLAUSE(Name, Class) \ +case OMPC_##Name: return ASTNodeKind(NKI_##Class); +#include "clang/Basic/OpenMPKinds.def" Well, I

[PATCH] D57112: [ASTTypeTraits] OMPClause handling

lebedev.ri created this revision. lebedev.ri added reviewers: sbenza, bkramer, pcc, klimek, hokein. lebedev.ri added a project: OpenMP. lebedev.ri added a child revision: D57113: [clang-tidy] openmp-use-default-none - a new module and a check. `OMPClause` is the base class, it is not descendant