This revision was automatically updated to reflect the committed changes.
Closed by commit rC354621: [Fixed Point Arithmetic] Fixed Point Comparisons
(authored by leonardchan, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D57219?vs=184886=187847#toc
Repository:
rC Clang
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
No, this LGTM.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57219/new/
https://reviews.llvm.org/D57219
___
leonardchan added a subscriber: bevinh.
leonardchan added a comment.
Herald added a subscriber: jdoerfert.
*ping* @bevinh @rjmccall @bjope Any other comments on this patch?
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57219/new/
https://reviews.llvm.org/D57219
rjmccall added inline comments.
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3444
case BO_NE:
+return Builder.CreateICmpNE(FullLHS, FullRHS);
+ case BO_Mul:
ebevhan wrote:
> ebevhan wrote:
> > rjmccall wrote:
> > > leonardchan wrote:
> > > > ebevhan
ebevhan added inline comments.
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3444
case BO_NE:
+return Builder.CreateICmpNE(FullLHS, FullRHS);
+ case BO_Mul:
ebevhan wrote:
> rjmccall wrote:
> > leonardchan wrote:
> > > ebevhan wrote:
> > > > rjmccall
ebevhan added inline comments.
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3444
case BO_NE:
+return Builder.CreateICmpNE(FullLHS, FullRHS);
+ case BO_Mul:
rjmccall wrote:
> leonardchan wrote:
> > rjmccall wrote:
> > > Are padding bits guaranteed zero
rjmccall added inline comments.
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3444
case BO_NE:
+return Builder.CreateICmpNE(FullLHS, FullRHS);
+ case BO_Mul:
leonardchan wrote:
> rjmccall wrote:
> > leonardchan wrote:
> > > rjmccall wrote:
> > > > Are
leonardchan added inline comments.
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3444
case BO_NE:
+return Builder.CreateICmpNE(FullLHS, FullRHS);
+ case BO_Mul:
rjmccall wrote:
> leonardchan wrote:
> > rjmccall wrote:
> > > Are padding bits guaranteed
leonardchan updated this revision to Diff 184886.
leonardchan marked an inline comment as done.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57219/new/
https://reviews.llvm.org/D57219
Files:
clang/lib/AST/ExprConstant.cpp
clang/lib/CodeGen/CGExprScalar.cpp
rjmccall added inline comments.
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3444
case BO_NE:
+return Builder.CreateICmpNE(FullLHS, FullRHS);
+ case BO_Mul:
leonardchan wrote:
> rjmccall wrote:
> > Are padding bits guaranteed zero or unspecified? Or
leonardchan added inline comments.
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3444
case BO_NE:
+return Builder.CreateICmpNE(FullLHS, FullRHS);
+ case BO_Mul:
rjmccall wrote:
> Are padding bits guaranteed zero or unspecified? Or are we just not
leonardchan updated this revision to Diff 184612.
leonardchan marked 3 inline comments as done.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57219/new/
https://reviews.llvm.org/D57219
Files:
clang/lib/AST/ExprConstant.cpp
clang/lib/CodeGen/CGExprScalar.cpp
rjmccall added inline comments.
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3444
case BO_NE:
+return Builder.CreateICmpNE(FullLHS, FullRHS);
+ case BO_Mul:
Are padding bits guaranteed zero or unspecified? Or are we just not really
supporting padding
bjope added inline comments.
Comment at: clang/test/Frontend/fixed_point_comparisons.c:2
+// RUN: %clang_cc1 -ffixed-point -triple x86_64-unknown-linux-gnu -S
-emit-llvm %s -o - | FileCheck %s --check-prefixes=CHECK,SIGNED
+// RUN: %clang_cc1 -ffixed-point -triple
leonardchan added inline comments.
Comment at: clang/test/Frontend/fixed_point_comparisons.c:56
+
+void TestComparisons() {
+ short _Accum sa;
ebevhan wrote:
> leonardchan wrote:
> > ebevhan wrote:
> > > Missing saturating and saturating/non-saturating
leonardchan updated this revision to Diff 183980.
leonardchan marked 2 inline comments as done.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57219/new/
https://reviews.llvm.org/D57219
Files:
clang/lib/AST/ExprConstant.cpp
clang/lib/CodeGen/CGExprScalar.cpp
ebevhan added inline comments.
Comment at: clang/test/Frontend/fixed_point_comparisons.c:56
+
+void TestComparisons() {
+ short _Accum sa;
leonardchan wrote:
> ebevhan wrote:
> > Missing saturating and saturating/non-saturating comparisons. I'd like to
> > see
leonardchan updated this revision to Diff 183629.
leonardchan marked 4 inline comments as done.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57219/new/
https://reviews.llvm.org/D57219
Files:
clang/lib/AST/ExprConstant.cpp
clang/lib/CodeGen/CGExprScalar.cpp
leonardchan added inline comments.
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:141
+ (RHSType->isFixedPointType() &&
+ LHSType->isFixedPointOrIntegerType());
+}
ebevhan wrote:
> Can't it just be `LHSType->isFixedPointType() ||
ebevhan added inline comments.
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:141
+ (RHSType->isFixedPointType() &&
+ LHSType->isFixedPointOrIntegerType());
+}
Can't it just be `LHSType->isFixedPointType() ||
leonardchan created this revision.
leonardchan added reviewers: rjmccall, bjope, ebevhan.
leonardchan added a project: clang.
leonardchan added a parent revision: D46917: [Fixed Point Arithmetic]
Comparison and Unary Operations for Fixed Point Types.
This patch implements fixed point comparisons
21 matches
Mail list logo
