riccibruno created this revision.
riccibruno added a reviewer: aaron.ballman.
riccibruno added a project: clang.
Herald added a subscriber: cfe-commits.
The description of what the various `Expr::Ignore*` do has drifted from the
actual implementation.
Inspection reveals that `IgnoreParenImpCasts
riccibruno updated this revision to Diff 183695.
riccibruno added a comment.
Removed superfluous braces added in some if statements.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57266/new/
https://reviews.llvm.org/D57266
Files:
include/clang/AST/Expr.h
incl
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM with some nits. Thank you for the cleaned up comments, these are helpful!
Comment at: include/clang/AST/Expr.h:749-750
+ /// reaching a fixed point. Skips
riccibruno marked 8 inline comments as done.
riccibruno added inline comments.
Comment at: include/clang/AST/Expr.h:749-750
+ /// reaching a fixed point. Skips:
+ /// * ImplicitCastExpr.
+ /// * FullExpr.
Expr *IgnoreImpCasts() LLVM_READONLY;
aaron.ballman
riccibruno updated this revision to Diff 184945.
riccibruno marked 4 inline comments as done.
riccibruno added a comment.
Addressed Aaron's comments.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57266/new/
https://reviews.llvm.org/D57266
Files:
include/clang/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL353006: [AST] Update the comments of the various
Expr::Ignore* + Related cleanups (authored by brunoricci, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed pr
