[PATCH] D57268: [dllimport] Don't use RAV to check inlinability

2019-01-25 Thread Hans Wennborg via Phabricator via cfe-commits
hans added a comment. Yes, it's a little bit unfortunate that the code needs to get more complicated due to this. The RecursiveStmtVisitor idea that you mention sounds like it might be a good idea (but if it turns out not to be, I'm not entirely opposed to this patch either). CHANGES SINCE LA

[PATCH] D57268: [dllimport] Don't use RAV to check inlinability

2019-01-25 Thread Reid Kleckner via Phabricator via cfe-commits
rnk created this revision. rnk added a reviewer: hans. I don't like this change, because I had to copy a fair amount of logic from RAV into the dllimport visitor. However, the build time and size results were still impressive, so I wanted to upload this and get a second opinion. Here's the data: