This revision was automatically updated to reflect the committed changes.
Closed by commit rC353425: [ASTImporter] Refactor unittests to be able to
parameterize them in a more… (authored by martong, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D57322?vs=184694=185786#toc
aaron.ballman accepted this revision.
aaron.ballman added a comment.
LGTM, though I am by no means a gtest expert.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57322/new/
https://reviews.llvm.org/D57322
___
shafik accepted this revision.
shafik added a comment.
This revision is now accepted and ready to land.
This looks reasonable to me but I don't have strong opinions on refactoring
gtest tests.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57322/new/
martong added a comment.
Update: I just removed the unrelated changes.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57322/new/
https://reviews.llvm.org/D57322
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
martong updated this revision to Diff 184694.
martong marked 2 inline comments as done.
martong added a comment.
Herald added a project: clang.
- Remove unrelated hunks
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57322/new/
https://reviews.llvm.org/D57322
shafik added inline comments.
Comment at: unittests/AST/ASTImporterTest.cpp:468
+ template DeclT *Import(DeclT *From, Language Lang) {
+return cast_or_null(Import(cast(From), Lang));
Is this being used in this PR?
Repository:
rC Clang
CHANGES SINCE
balazske added inline comments.
Comment at: unittests/AST/ASTImporterTest.cpp:15
+// FIXME: Better solution for this?
+#define GTEST_HAS_COMBINE 1
+
Define of this is related to the new visibility tests, but not a problem is
this remains here (there is another
martong created this revision.
martong added reviewers: a_sidorin, shafik.
Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs.
Herald added a reviewer: a.sidorin.
Currently `TestImportBase` is derived from `ParameterizedTestsFixture`
which explicitly states that the
