[PATCH] D57860: [analyzer] Validate checker option names and values

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL361011: [analyzer] Validate checker option names and values (authored by Szelethus, committed by ). Herald added a project

[PATCH] D57860: [analyzer] Validate checker option names and values

NoQ accepted this revision. NoQ added a comment. In D57860#1432728 , @dcoughlin wrote: > Setting compatibility mode to be true in the driver is not sufficient since > many build systems call the frontend directly. This doesn't seem to be the case; all b

[PATCH] D57860: [analyzer] Validate checker option names and values

Szelethus added a comment. Ping^4 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57860/new/ https://reviews.llvm.org/D57860 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D57860: [analyzer] Validate checker option names and values

Szelethus added a comment. Ping^3 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57860/new/ https://reviews.llvm.org/D57860 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D57860: [analyzer] Validate checker option names and values

Szelethus added a comment. Ping^2 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57860/new/ https://reviews.llvm.org/D57860 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D57860: [analyzer] Validate checker option names and values

Szelethus added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57860/new/ https://reviews.llvm.org/D57860 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D57860: [analyzer] Validate checker option names and values

Szelethus added a comment. In D57860#1432728 , @dcoughlin wrote: > I think it would be better if the default for compatibility mode were 'true'. > That way this change will be backwards compatible and clients who want to > enforce stricter checking could

[PATCH] D57860: [analyzer] Validate checker option names and values

baloghadamsoftware added a comment. In D57860#1432728 , @dcoughlin wrote: > I think it would be better if the default for compatibility mode were 'true'. > That way this change will be backwards compatible and clients who want to > enforce stricter check

[PATCH] D57860: [analyzer] Validate checker option names and values

dcoughlin requested changes to this revision. dcoughlin added a comment. This revision now requires changes to proceed. I think it would be better if the default for compatibility mode were 'true'. That way this change will be backwards compatible and clients who want to enforce stricter checkin

[PATCH] D57860: [analyzer] Validate checker option names and values

Szelethus updated this revision to Diff 190992. Szelethus added a comment. Add a test case for checker plugins. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57860/new/ https://reviews.llvm.org/D57860 Files: include/clang/Basic/DiagnosticDriverKinds.td include/clang/StaticAnalyzer/

[PATCH] D57860: [analyzer] Validate checker option names and values

Szelethus updated this revision to Diff 190981. Szelethus added a comment. Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57860/new/ https://reviews.llvm.org/D57860 Files: include/clang/Basic/DiagnosticDriverKinds.td include/clang/StaticAnalyzer/Frontend/CheckerRegistry.h

[PATCH] D57860: [analyzer] Validate checker option names and values

Szelethus updated this revision to Diff 190630. Szelethus added a comment. Add a testcase for packages. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57860/new/ https://reviews.llvm.org/D57860 Files: include/clang/Basic/DiagnosticDriverKinds.td include/clang/StaticAnalyzer/Frontend

[PATCH] D57860: [analyzer] Validate checker option names and values

Szelethus updated this revision to Diff 190629. Szelethus marked 6 inline comments as done. Szelethus added a comment. Fixes according to inline comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57860/new/ https://reviews.llvm.org/D57860 Files: include/clang/Basic/DiagnosticDri

[PATCH] D57860: [analyzer] Validate checker option names and values

xazax.hun added a comment. Did we test all the codepaths including the package level configs? If not, please add some package level config option related tests. Otherwise the patch looks good to me after all the comments are resolved. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57860/

[PATCH] D57860: [analyzer] Validate checker option names and values

baloghadamsoftware added inline comments. Comment at: lib/StaticAnalyzer/Frontend/CheckerRegistry.cpp:325 + std::string FullOption = + (llvm::Twine() + FullName + ":" + OptionName).str(); + whisperity wrote: > baloghadamsoftware wrote: > > Is this the most

[PATCH] D57860: [analyzer] Validate checker option names and values

whisperity added inline comments. Comment at: lib/StaticAnalyzer/Frontend/CheckerRegistry.cpp:325 + std::string FullOption = + (llvm::Twine() + FullName + ":" + OptionName).str(); + baloghadamsoftware wrote: > Is this the most efficient way to concatenate `

[PATCH] D57860: [analyzer] Validate checker option names and values

baloghadamsoftware added inline comments. Comment at: lib/StaticAnalyzer/Frontend/CheckerRegistry.cpp:325 + std::string FullOption = + (llvm::Twine() + FullName + ":" + OptionName).str(); + Is this the most efficient way to concatenate `StringRef`s? =

[PATCH] D57860: [analyzer] Validate checker option names and values

Szelethus marked 2 inline comments as done. Szelethus added inline comments. Comment at: lib/StaticAnalyzer/Frontend/CheckerRegistry.cpp:340 + if (OptionType == "bool") { +if (SuppliedValue != "true" && SuppliedValue != "false") { + if (AnOpts.ShouldEmitErrorsOnInvalidC

[PATCH] D57860: [analyzer] Validate checker option names and values

whisperity added inline comments. Comment at: lib/StaticAnalyzer/Frontend/CheckerRegistry.cpp:329 + + // Insertation was successful -- CmdLineOption's constructor will validate + // whether values received from plugins or TableGen files are correct. Insertion

[PATCH] D57860: [analyzer] Validate checker option names and values

Szelethus updated this revision to Diff 190023. Szelethus added a comment. Herald added subscribers: Charusso, jdoerfert. Refactored the entire patch, NFC compared to the earlier diff. This was needed as in a followup revision, much of the code would be rewritten. CHANGES SINCE LAST ACTION ht

[PATCH] D57860: [analyzer] Validate checker option names and values

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. > (already in the works!) Document the frontend of the analyzer, sneak peak > here. Whoa!! *celebrates the graphomania epidemic* Repository: rC Clang CHANGES SINCE LAST ACTION https://review

[PATCH] D57860: [analyzer] Validate checker option names and values

Szelethus created this revision. Szelethus added reviewers: NoQ, george.karpenkov, xazax.hun, rnkovacs, baloghadamsoftware. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, whisperity. Herald added a project: clang. Validate whether the op