[PATCH] D57883: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer

bjope added inline comments. Comment at: clang-tidy/utils/ExceptionAnalyzer.h:112 +/// throw, if it's unknown or if it won't throw. +enum State Behaviour : 2; + JonasToth wrote: > bjope wrote: > > (post-commit comments) > > > > I've seen that @dyung did

[PATCH] D57883: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer

JonasToth marked an inline comment as done. JonasToth added inline comments. Comment at: clang-tidy/utils/ExceptionAnalyzer.h:112 +/// throw, if it's unknown or if it won't throw. +enum State Behaviour : 2; + bjope wrote: > (post-commit comments) > > I'v

[PATCH] D57883: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer

bjope added a subscriber: sammccall. bjope added a comment. Maybe @sammccall remembers why it was decided to rewrite the enum into constexpr:s in https://reviews.llvm.org/rCTE319608 ? Do we need a similar solution here? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://

[PATCH] D57883: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer

bjope added subscribers: dyung, bjope. bjope added inline comments. Herald added a subscriber: Charusso. Comment at: clang-tidy/utils/ExceptionAnalyzer.h:112 +/// throw, if it's unknown or if it won't throw. +enum State Behaviour : 2; + (post-commit comme

[PATCH] D57883: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE354517: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer (authored by JonasToth, committed by ). Changed prior to commit: https://reviews.llvm.org/D57883?vs=187635&id=187662#toc

[PATCH] D57883: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer

JonasToth updated this revision to Diff 187635. JonasToth marked an inline comment as done. JonasToth added a comment. - be explicit about the State enumerator values Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57883/new/ https://reviews.llvm.org/

[PATCH] D57883: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer

JonasToth marked 3 inline comments as done. JonasToth added a comment. all comments resolved. I will land this now. Comment at: clang-tidy/utils/ExceptionAnalyzer.h:26-31 + enum class State : std::int8_t { +Throwing,///< The function can definitly throw given an AST. +

[PATCH] D57883: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer

JonasToth updated this revision to Diff 187634. JonasToth marked 2 inline comments as done. JonasToth added a comment. - [Refactor] move support classes into the analyzer - [Refactor] move bigger methods into implementation file - minor adjustments Repository: rCTE Clang Tools Extra CHANGES S

[PATCH] D57883: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer

baloghadamsoftware accepted this revision. baloghadamsoftware added a comment. In D57883#1402049 , @lebedev.ri wrote: > It's for D57108 , i'we guessed that such > ternary answer will be required there. Oh, I was not awar

[PATCH] D57883: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer

lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. Sorry for the reviews, i'm really stalling it seems.. This looks like a straight-forward change, but i'm not sure i'm familiar enough with ExceptionAnalyzer to fully properly review th

[PATCH] D57883: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer

baloghadamsoftware added a comment. If I understand it correctly, this is more of an infrastructure improvement than check enhancement. It looks like a nice and clean code. Where do we expect to use this new behavior? In the current check or in the upcoming "modernize" check? ===

[PATCH] D57883: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer

JonasToth added a comment. ping :) Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57883/new/ https://reviews.llvm.org/D57883 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D57883: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer

JonasToth marked 2 inline comments as done. JonasToth added a comment. Good idea :) Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57883/new/ https://reviews.llvm.org/D57883 ___ cfe-commits mailing list

[PATCH] D57883: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer

JonasToth updated this revision to Diff 185939. JonasToth added a comment. - [Refactor] move support classes into the analyzer - [Refactor] move bigger methods into implementation file Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57883/new/ https:/

[PATCH] D57883: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer

lebedev.ri added inline comments. Comment at: clang-tidy/utils/ExceptionAnalyzer.h:31-192 +enum class ExceptionState : std::int8_t { + Throwing,///< The function can definitly throw given an AST. + NotThrowing, ///< This function can not throw, given an AST. + Unknown,

[PATCH] D57883: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer

JonasToth marked 2 inline comments as done. JonasToth added inline comments. Comment at: clang-tidy/utils/ExceptionAnalyzer.h:31-192 +enum class ExceptionState : std::int8_t { + Throwing,///< The function can definitly throw given an AST. + NotThrowing, ///< This function c

[PATCH] D57883: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer

lebedev.ri added a comment. Exciting! Comment at: clang-tidy/utils/ExceptionAnalyzer.h:31-192 +enum class ExceptionState : std::int8_t { + Throwing,///< The function can definitly throw given an AST. + NotThrowing, ///< This function can not throw, given an AST. + Unknow

[PATCH] D57883: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer

JonasToth created this revision. JonasToth added reviewers: lebedev.ri, aaron.ballman, baloghadamsoftware, alexfh. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, a.sidorin, rnkovacs, xazax.hun. Herald added a project: clang. The analsis on the throwing behvaiour on functio