[PATCH] D57891: [analyzer] Fix infinite recursion in printing macros

2019-03-08 Thread Kristóf Umann via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL355705: [analyzer] Fix infinite recursion in printing macros (authored by Szelethus, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https

[PATCH] D57891: [analyzer] Fix infinite recursion in printing macros

2019-03-07 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. Well, yea, getting rid of a crash is great, it's kind of bummer that can't expand the macro properly in the testfile. I really fear that we need a far greater overhaul of this entire eff

[PATCH] D57891: [analyzer] Fix infinite recursion in printing macros

2019-03-07 Thread Tibor Brunner via Phabricator via cfe-commits
bruntib updated this revision to Diff 189670. bruntib added a comment. Herald added subscribers: Charusso, jdoerfert, whisperity. I added a test case for this recursive case. There is also a TODO in the code indicating the place where an additional fix will be required. Repository: rC Clang

[PATCH] D57891: [analyzer] Fix infinite recursion in printing macros

2019-02-07 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a comment. Is there a chance of obtaining a testcase for this? I would very strongly prefer one. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57891/new/ https://reviews.llvm.org/D57891 ___ cfe-commi

[PATCH] D57891: [analyzer] Fix infinite recursion in printing macros

2019-02-07 Thread Tibor Brunner via Phabricator via cfe-commits
bruntib created this revision. bruntib added reviewers: NoQ, george.karpenkov, Szelethus, xazax.hun. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. Herald added a project: clang. #define f(y) x #define x f(x) int main()