[PATCH] D57948: [Sema] Fix a regression introduced in "[AST][Sema] Remove CallExpr::setNumArgs"

hans removed a subscriber: hansw. hans added a comment. In D57948#1399683 , @riccibruno wrote: > Done, thanks! That was https://bugs.llvm.org/show_bug.cgi?id=40742 and it's now been merged. Repository: rC Clang CHANGES SINCE LAST ACTION https://re

[PATCH] D57948: [Sema] Fix a regression introduced in "[AST][Sema] Remove CallExpr::setNumArgs"

riccibruno added a comment. Done, thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57948/new/ https://reviews.llvm.org/D57948 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[PATCH] D57948: [Sema] Fix a regression introduced in "[AST][Sema] Remove CallExpr::setNumArgs"

aaron.ballman added a subscriber: hansw. aaron.ballman added a comment. In D57948#1399403 , @riccibruno wrote: > (Following up on a discussion on IRC) I have looked at what would be needed > to revert the set of patches which introduced this change, but t

[PATCH] D57948: [Sema] Fix a regression introduced in "[AST][Sema] Remove CallExpr::setNumArgs"

riccibruno added a subscriber: hans. riccibruno added a comment. (Following up on a discussion on IRC) I have looked at what would be needed to revert the set of patches which introduced this change, but this results in a >1k lines diff which do not apply cleanly. I think it might be safer to ju

[PATCH] D57948: [Sema] Fix a regression introduced in "[AST][Sema] Remove CallExpr::setNumArgs"

This revision was automatically updated to reflect the committed changes. Closed by commit rC354035: [Sema] Fix a regression introduced in "[AST][Sema] Remove CallExpr::setNumArgs" (authored by brunoricci, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D57948: [Sema] Fix a regression introduced in "[AST][Sema] Remove CallExpr::setNumArgs"

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57948/new/ https://reviews.llvm.org/D57948 ___

[PATCH] D57948: [Sema] Fix a regression introduced in "[AST][Sema] Remove CallExpr::setNumArgs"

riccibruno updated this revision to Diff 186449. riccibruno added a comment. Rewrote the patch to make it local to `BuildResolvedCallExpr`. It is still a hack though. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57948/new/ https://reviews.llvm.org/D57948 Files

[PATCH] D57948: [Sema] Fix a regression introduced in "[AST][Sema] Remove CallExpr::setNumArgs"

aaron.ballman added inline comments. Comment at: lib/AST/Expr.cpp:1272-1274 + for (unsigned I = NumArgs; I != NumArgsAllocated; ++I) { +TrailingArgs[I] = nullptr; } Could use `std::fill()` here to remove the for-loop. Your call whether that looks cleaner

[PATCH] D57948: [Sema] Fix a regression introduced in "[AST][Sema] Remove CallExpr::setNumArgs"

riccibruno created this revision. riccibruno added a reviewer: aaron.ballman. riccibruno added a project: clang. Herald added a subscriber: cfe-commits. D54902 removed `CallExpr::setNumArgs` in preparation of tail-allocating the arguments of `CallExpr`. It did th