[PATCH] D57978: [CodeGen] Generate follow-up metadata for loops with more than one transformation.

This revision was automatically updated to reflect the committed changes. Closed by commit rL357415: [CodeGen] Generate follow-up metadata for loops with more than one… (authored by Meinersbur, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D57978: [CodeGen] Generate follow-up metadata for loops with more than one transformation.

Meinersbur added a comment. @dmgreen Thank you for the review! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57978/new/ https://reviews.llvm.org/D57978 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D57978: [CodeGen] Generate follow-up metadata for loops with more than one transformation.

Meinersbur added a comment. ping The Polly-powered additional transformations now also generate this kind of metadata. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57978/new/ https://reviews.llvm.org/D57978 ___

[PATCH] D57978: [CodeGen] Generate follow-up metadata for loops with more than one transformation.

Meinersbur added a comment. ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57978/new/ https://reviews.llvm.org/D57978 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[PATCH] D57978: [CodeGen] Generate follow-up metadata for loops with more than one transformation.

hsaito added a comment. In D57978#1435473 , @Meinersbur wrote: > ping This is a good follow up for rL348944 , but I have no familiarity to the code under Clang. So, let me thank you for doing this work and move myself

[PATCH] D57978: [CodeGen] Generate follow-up metadata for loops with more than one transformation.

dmgreen added a comment. Hello. I also don't feel very familiar with clang, but had a poke around and I think it looks pretty good. I see unroll and jam is being awkward again. This could maybe do with a few extra tests. Am I correct in saying something like this: #pragma unroll_and_jam(4)

[PATCH] D57978: [CodeGen] Generate follow-up metadata for loops with more than one transformation.

Meinersbur updated this revision to Diff 192194. Meinersbur marked 5 inline comments as done. Meinersbur added a comment. - Rebase - Add two test cases for all attributes combined (as inner and outer loop for of an unroll-and-jam) - Of two nested unroll-and-jams, apply the inner first - Typos and

[PATCH] D57978: [CodeGen] Generate follow-up metadata for loops with more than one transformation.

Meinersbur added a comment. In D57978#1440894 , @dmgreen wrote: > This could maybe do with a few extra tests. Am I correct in saying something > like this: > > #pragma unroll_and_jam(4) > for(int j = 0; j < n; j++) { > #pragma unroll(4) > for(

[PATCH] D57978: [CodeGen] Generate follow-up metadata for loops with more than one transformation.

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. Yeah, OK. This looks like a good patch to me. As I said, I'm not a clang expert, but the code looks sensible enough. (Perhaps wait a couple of days in case others have objections.) Reposit

[PATCH] D57978: [CodeGen] Generate follow-up metadata for loops with more than one transformation.

Meinersbur created this revision. Meinersbur added reviewers: hfinkel, aaron.ballman, hsaito, dmgreen, anemet, rjmccall, Anastasia, pekka.jaaskelainen, meheff, tyler.nowicki. Herald added a subscriber: zzheng. Herald added a project: clang. Before this patch, CGLoop would dump all transformations

[PATCH] D57978: [CodeGen] Generate follow-up metadata for loops with more than one transformation.

rjmccall resigned from this revision. rjmccall added a comment. Herald added a subscriber: jdoerfert. Sorry, this is deep in the loop analysis code, and I don't remember anything about this stuff, so I'm not sure I'm going to be a useful reviewer. Repository: rC Clang CHANGES SINCE LAST ACTI

[PATCH] D57978: [CodeGen] Generate follow-up metadata for loops with more than one transformation.

Anastasia resigned from this revision. Anastasia added a comment. This seems like an interesting change. So far in OpenCL we have actively used only unroll. I will let others to assess in more details. Comment at: lib/CodeGen/CGLoopInfo.cpp:107 + FollowupLoopProperties.push_b

[PATCH] D57978: [CodeGen] Generate follow-up metadata for loops with more than one transformation.

Meinersbur marked an inline comment as done. Meinersbur added inline comments. Comment at: lib/CodeGen/CGLoopInfo.cpp:107 + FollowupLoopProperties.push_back( + MDNode::get(Ctx, MDString::get(Ctx, "llvm.loop.unroll.disable"))); + Anastasia wrote: > Will this