[PATCH] D58091: Customize warnings for missing built-in type

This revision was automatically updated to reflect the committed changes. Closed by commit rL367387: [Fix] Customize warnings for missing built-in types (authored by jdoerfert, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D58091: Customize warnings for missing built-in type

jdoerfert updated this revision to Diff 212500. jdoerfert added a comment. Fix spelling in tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58091/new/ https://reviews.llvm.org/D58091 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D58091: Customize warnings for missing built-in type

bcain accepted this revision. bcain added a comment. Herald added a subscriber: dmgreen. @jdoerfert @jyknight @lebedev.ri@rsmith @aaron.ballman This will appear as a 9.0 regression, right? Let's please consider a way to address it for 9.0 before it's released. Repository: rG LLVM

[PATCH] D58091: Customize warnings for missing built-in type

bcain added a comment. In D58091#1397586 , @jyknight wrote: > I think this warning (-Wbuiltin-requires-header) doesn't really make sense as > its own warning. > > We already have two related (on-by-default) warnings. ... In D58091#1414250

[PATCH] D58091: Customize warnings for missing built-in type

bcain added a comment. In D58091#1409584 , @jdoerfert wrote: > I did address the comments but I will wait until I hear back on the "warning > vs warning + note question". ... > I do not have strong feelings about this, either way is fine with me. >

[PATCH] D58091: Customize warnings for missing built-in type

jdoerfert updated this revision to Diff 188411. jdoerfert marked an inline comment as done. jdoerfert added a comment. Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58091/new/ https://reviews.llvm.org/D58091 Files:

[PATCH] D58091: Customize warnings for missing built-in type

bcain added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:592 +: Warning<"declaration of built-in function '%0' requires the declaration" +" of the 'jmp_buf' type, commonly proived in the header .">, + InGroup>;

[PATCH] D58091: Customize warnings for missing built-in type

jdoerfert added a comment. I did address the comments but I will wait until I hear back on the "warning vs warning + note question". In D58091#1397586 , @jyknight wrote: > I think this warning (-Wbuiltin-requires-header) doesn't really make sense as >

[PATCH] D58091: Customize warnings for missing built-in type

jdoerfert updated this revision to Diff 188238. jdoerfert marked 3 inline comments as done. jdoerfert added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58091/new/ https://reviews.llvm.org/D58091 Files:

[PATCH] D58091: Customize warnings for missing built-in type

bcain accepted this revision. bcain added a comment. This revision is now accepted and ready to land. I can confirm that this fix is effective at addressing the problem we experienced. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58091/new/

[PATCH] D58091: Customize warnings for missing built-in type

jyknight added a comment. I think this warning (-Wbuiltin-requires-header) doesn't really make sense as its own warning. We already have two related (on-by-default) warnings. For declarations: test.c:1:6: warning: incompatible redeclaration of library function 'exit'

[PATCH] D58091: Customize warnings for missing built-in type

rsmith added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:591 +def warn_implicit_decl_no_jmp_buf +: Warning<"declaration of built-in '%0' requires the definition of the " + "'jmp_buf' type">, We only require a

[PATCH] D58091: Customize warnings for missing built-in type

jdoerfert added a comment. In D58091#1396437 , @aaron.ballman wrote: > In D58091#1396397 , @jdoerfert wrote: > > > In D58091#1396382 , @aaron.ballman > > wrote: > > > > >

[PATCH] D58091: Customize warnings for missing built-in type

bcain added a comment. > Are you sure it is unrelated? Very nearly positive, I applied the patch to our downstream trunk and the assertion is encountered in a target-specific pass. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58091/new/

[PATCH] D58091: Customize warnings for missing built-in type

aaron.ballman added a comment. In D58091#1396397 , @jdoerfert wrote: > In D58091#1396382 , @aaron.ballman > wrote: > > > - but I wonder why those diagnostics are happening in the first place. It > > seems like

[PATCH] D58091: Customize warnings for missing built-in type

jdoerfert added a comment. In D58091#1396393 , @bcain wrote: > I reported PR40692. I just tried this patch on our local build where we saw > the failure on an RTOS implementing pthreads. Unfortunately with this patch > I encountered an (unrelated)

[PATCH] D58091: Customize warnings for missing built-in type

jdoerfert added a comment. In D58091#1396382 , @aaron.ballman wrote: > If I'm following along properly, it sounds like we want to disable this > warning largely because it can appear in header files attempting to declare > the functions in question.

[PATCH] D58091: Customize warnings for missing built-in type

bcain added a comment. I reported PR40692. I just tried this patch on our local build where we saw the failure on an RTOS implementing pthreads. Unfortunately with this patch I encountered an (unrelated) assertion. So this fix was inconclusive for me (for now). I will follow up but if this

[PATCH] D58091: Customize warnings for missing built-in type

aaron.ballman added a reviewer: rsmith. aaron.ballman added a comment. If I'm following along properly, it sounds like we want to disable this warning largely because it can appear in header files attempting to declare the functions in question -- but I wonder why those diagnostics are

[PATCH] D58091: Customize warnings for missing built-in type

jdoerfert created this revision. jdoerfert added reviewers: jyknight, lebedev.ri, aaron.ballman, bcain. Herald added subscribers: jfb, bollu, krytarowski, emaste. Herald added a project: clang. If we detect a built-in declaration for which we cannot derive a type matching the pattern in the