This revision was automatically updated to reflect the committed changes.
Closed by commit rL371655: Fix -Wnonportable-include-path suppression for
header maps with absolute paths. (authored by vsapsai, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
vsapsai marked 2 inline comments as done.
vsapsai added a comment.
Thanks for the review.
Comment at: clang/lib/Lex/HeaderSearch.cpp:892-902
+IsInHeaderMap, MappedName);
+if (!MappedName.empty()) {
+ assert(IsInHeaderMap && "MappedName should come from a
dexonsmith accepted this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.
LGTM. I have one idea for you to consider inline.
Comment at: clang/lib/Lex/HeaderSearch.cpp:892-902
+IsInHeaderMap, MappedName);
+if
vsapsai marked 4 inline comments as done.
vsapsai added a comment.
Updated the code. Hope it is easier to understand now.
Comment at: clang/lib/Lex/HeaderSearch.cpp:908-909
+if (IsMapped)
+ *IsMapped = CurrentInHeaderMap || HasBeenMapped;
+
vsapsai updated this revision to Diff 219194.
vsapsai added a comment.
- Add a test for unused absolute path in a header map; simplify code.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58094/new/
https://reviews.llvm.org/D58094
Files:
clang/include/clang/Lex/DirectoryLookup.h
vsapsai marked 3 inline comments as done.
vsapsai added inline comments.
Comment at: clang/lib/Lex/HeaderSearch.cpp:888
bool InUserSpecifiedSystemFramework = false;
-bool HasBeenMapped = false;
+bool CurrentInHeaderMap = false;
bool IsFrameworkFoundInDir =
dexonsmith added inline comments.
Comment at: clang/lib/Lex/HeaderSearch.cpp:888
bool InUserSpecifiedSystemFramework = false;
-bool HasBeenMapped = false;
+bool CurrentInHeaderMap = false;
bool IsFrameworkFoundInDir = false;
Why not name this
vsapsai updated this revision to Diff 218794.
vsapsai added a comment.
Herald added a subscriber: ributzka.
- Rebase the patch.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58094/new/
https://reviews.llvm.org/D58094
Files:
clang/include/clang/Lex/DirectoryLookup.h
vsapsai added a comment.
Ping.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58094/new/
https://reviews.llvm.org/D58094
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vsapsai added a comment.
Ping.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58094/new/
https://reviews.llvm.org/D58094
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vsapsai added a comment.
Ping.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58094/new/
https://reviews.llvm.org/D58094
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vsapsai added a comment.
Ping.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58094/new/
https://reviews.llvm.org/D58094
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vsapsai marked an inline comment as done.
vsapsai added inline comments.
Comment at: clang/lib/Lex/HeaderSearch.cpp:388
} else {
Result = HS.getFileMgr().getFile(Dest);
}
I have considered changing this to `.getFile(Dest, /*OpenFile=*/true)` so that
vsapsai created this revision.
vsapsai added reviewers: dexonsmith, bruno.
Herald added a subscriber: jkorous.
In `DirectoryLookup::LookupFile` parameter `HasBeenMapped` doesn't cover
the case when clang finds a file through a header map but doesn't remap
the lookup filename because the target
14 matches
Mail list logo
