[PATCH] D58120: [Builtins] Treat `bcmp` as a builtin.

This revision was automatically updated to reflect the committed changes. Closed by commit rC354023: [Builtins] Treat `bcmp` as a builtin. (authored by courbet, committed by ). Changed prior to commit: https://reviews.llvm.org/D58120?vs=186651=186814#toc Repository: rC Clang CHANGES SINCE

[PATCH] D58120: [Builtins] Treat `bcmp` as a builtin.

courbet added a comment. Thanks. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58120/new/ https://reviews.llvm.org/D58120 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D58120: [Builtins] Treat `bcmp` as a builtin.

efriedma accepted this revision. efriedma added a comment. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58120/new/ https://reviews.llvm.org/D58120 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D58120: [Builtins] Treat `bcmp` as a builtin.

jyknight accepted this revision. jyknight added a comment. This revision is now accepted and ready to land. Looks reasonable to me. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58120/new/ https://reviews.llvm.org/D58120

[PATCH] D58120: [Builtins] Treat `bcmp` as a builtin.

courbet updated this revision to Diff 186651. courbet added a comment. Update tests after constness changes. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58120/new/ https://reviews.llvm.org/D58120 Files: include/clang/Basic/Builtins.def lib/AST/Decl.cpp

[PATCH] D58120: [Builtins] Treat `bcmp` as a builtin.

courbet updated this revision to Diff 186645. courbet added a comment. - add __builtin_bcmp constant evaluation tests. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58120/new/ https://reviews.llvm.org/D58120 Files: include/clang/Basic/Builtins.def

[PATCH] D58120: [Builtins] Treat `bcmp` as a builtin.

courbet updated this revision to Diff 186644. courbet added a comment. Herald added a subscriber: jdoerfert. - Add tests for warnings. - Fix signature for intrinsic. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58120/new/ https://reviews.llvm.org/D58120 Files:

[PATCH] D58120: [Builtins] Treat `bcmp` as a builtin.

efriedma added a comment. This looks essentially fine, but I'd like to see some basic test coverage for the changes to warnings and constant evaluation. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58120/new/ https://reviews.llvm.org/D58120

[PATCH] D58120: [Builtins] Treat `bcmp` as a builtin.

courbet created this revision. courbet added a reviewer: jyknight. Herald added a subscriber: kristina. Herald added a project: clang. This makes it consistent with `memcmp` and `__builtin_bcmp`. Also see the discussion in https://reviews.llvm.org/D56593. Repository: rC Clang