This revision was automatically updated to reflect the committed changes.
Closed by commit rL354272: [clangd] Add tests for template specializations
(authored by kadircet, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
CHANGES SINCE L
kadircet updated this revision to Diff 187237.
kadircet marked an inline comment as done.
kadircet added a comment.
- Fix typo and make comments start with 2 slashes
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58190/new/
https://reviews.llvm.org/D
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM with a typo-nit :-)
Comment at: unittests/clangd/XRefsTests.cpp:378
+
+ R"cpp(// partial tmeplate specialization
+template
s
kadircet updated this revision to Diff 187213.
kadircet added a comment.
- Add more testcases
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58190/new/
https://reviews.llvm.org/D58190
Files:
unittests/clangd/XRefsTests.cpp
Index: unittests/clang
ilya-biryukov added inline comments.
Comment at: unittests/clangd/XRefsTests.cpp:376
+}
+ )cpp",
};
While here, could wee add tests for a few more cases? They are all represented
by different classes in a hierarchy in clang, so each could potenti
kadircet created this revision.
Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric,
ilya-biryukov.
Herald added a project: clang.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D58190
Files:
unittests/clangd/XRefsTests.cpp
Index: unittests/clangd/XRefsT
